You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/08/13 02:01:27 UTC
Re: Review Request 37277: Added Heartbeater to master to send periodic
heartbeats to HTTP schedulers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37277/
-----------------------------------------------------------
(Updated Aug. 13, 2015, 12:01 a.m.)
Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
Changes
-------
refactored heartbeater per benm's comments. PTAL.
Summary (updated)
-----------------
Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.
Bugs: MESOS-3131
https://issues.apache.org/jira/browse/MESOS-3131
Repository: mesos
Description
-------
Just wanted to send out the abstraction for feedback.
Diffs (updated)
-----
src/internal/evolve.hpp 2e0355960c8c771f28f3ed4428cc047e5787fff7
src/internal/evolve.cpp 4678d67c8324e5c15188b5454e7cc6165d22d9bc
src/master/constants.hpp 7cec18b7fdfd3b96cde42a30d217c026b2695dce
src/master/constants.cpp fbcae60c43e835f96ec061bd0e9f7961e31fc341
src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3
src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048
src/tests/http_api_tests.cpp aef3c4b2c69fc14f67aa6f82309706b3fec99348
Diff: https://reviews.apache.org/r/37277/diff/
Testing (updated)
-------
make check
Updated the tests.
Thanks,
Vinod Kone
Re: Review Request 37277: Added Heartbeater to master to send periodic
heartbeats to HTTP schedulers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37277/#review95225
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37277]
All tests passed.
- Mesos ReviewBot
On Aug. 13, 2015, 12:01 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37277/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 12:01 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
>
>
> Bugs: MESOS-3131
> https://issues.apache.org/jira/browse/MESOS-3131
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Just wanted to send out the abstraction for feedback.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp 2e0355960c8c771f28f3ed4428cc047e5787fff7
> src/internal/evolve.cpp 4678d67c8324e5c15188b5454e7cc6165d22d9bc
> src/master/constants.hpp 7cec18b7fdfd3b96cde42a30d217c026b2695dce
> src/master/constants.cpp fbcae60c43e835f96ec061bd0e9f7961e31fc341
> src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3
> src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048
> src/tests/http_api_tests.cpp aef3c4b2c69fc14f67aa6f82309706b3fec99348
>
> Diff: https://reviews.apache.org/r/37277/diff/
>
>
> Testing
> -------
>
> make check
>
> Updated the tests.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 37277: Added Heartbeater to master to send periodic
heartbeats to HTTP schedulers.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37277/#review95285
-----------------------------------------------------------
Ship it!
src/master/master.hpp (line 1287)
<https://reviews.apache.org/r/37277/#comment150143>
This could be const& like the others since you're taking a copy, like the others.
src/master/master.hpp (lines 1602 - 1619)
<https://reviews.apache.org/r/37277/#comment150146>
Looking at the callsites and the implementation, this looks like disconnect(), maybe a TODO to rename it? Ideally telling the reader why this doesn't set 'connected' to false when it is closing the connection?
- Ben Mahler
On Aug. 13, 2015, 12:01 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37277/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 12:01 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
>
>
> Bugs: MESOS-3131
> https://issues.apache.org/jira/browse/MESOS-3131
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Just wanted to send out the abstraction for feedback.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp 2e0355960c8c771f28f3ed4428cc047e5787fff7
> src/internal/evolve.cpp 4678d67c8324e5c15188b5454e7cc6165d22d9bc
> src/master/constants.hpp 7cec18b7fdfd3b96cde42a30d217c026b2695dce
> src/master/constants.cpp fbcae60c43e835f96ec061bd0e9f7961e31fc341
> src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3
> src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048
> src/tests/http_api_tests.cpp aef3c4b2c69fc14f67aa6f82309706b3fec99348
>
> Diff: https://reviews.apache.org/r/37277/diff/
>
>
> Testing
> -------
>
> make check
>
> Updated the tests.
>
>
> Thanks,
>
> Vinod Kone
>
>