[GitHub] sarveshkesharwani commented on issue #940: Netbeans 1074 web.struts donation review

[GitBox <gi...@apache.org>]

sarveshkesharwani commented on issue #940: Netbeans 1074 web.struts donation review
URL: https://github.com/apache/incubator-netbeans/pull/940#issuecomment-428903983
 
 
   @matthiasblaesing , I have made the following changes in the latest commit : 
   - I have made fixes to build.xml and the build works fine now
   - The notice files in struts libraries contained the same text which was also equal to the NOTICE.txt present in `struts-1.3.10-lib.zip`, so I created a NOTICE.txt in the external folder
   
   The web.struts-external-resources.zip file was created during the last donation by combining the contents from `src/org/netbeans/modules/web/struts/resources/` folder, but some configuration files also got roped in which were specific to the resources that were being used. So, I have added the following files directly to `src/org/netbeans/modules/web/struts/resources/` with Apache-2.0 license header
   
   - struts.xml
   - struts-config.xml
   - validation.xml
   - tiles-defs.xml
   - struts-config_1_2.mdd
   - welcome.jsp
   
   Other than the aforementioned files, there were two more files present in `struts-1.3.10-lib.zip`, : 
   - struts-config_1_2-custom.dtd
   - struts-config_1_3-custom.dtd
   
   I think that these custom files were derived from struts-config_1_2.dtd and struts-config_1_3.dtd respectively, but I am not really sure about it. So, should we go ahead and add these two files with Apache-2.0 license? 
   Also, does the overall approach for this module seem fine?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists