You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by pt...@apache.org on 2016/01/20 23:06:21 UTC
[08/18] storm git commit: use string formatters vs. concatenation
use string formatters vs. concatenation
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/d9f09c9d
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/d9f09c9d
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/d9f09c9d
Branch: refs/heads/1.x-branch
Commit: d9f09c9da6ff0d331eb82efe2c3525cb4dd92883
Parents: 526a43b
Author: P. Taylor Goetz <pt...@gmail.com>
Authored: Fri Jan 8 14:31:43 2016 -0500
Committer: P. Taylor Goetz <pt...@gmail.com>
Committed: Fri Jan 8 14:31:43 2016 -0500
----------------------------------------------------------------------
.../main/java/org/apache/storm/mqtt/common/MqttUtils.java | 2 +-
.../java/org/apache/storm/mqtt/StormMqttIntegrationTest.java | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/d9f09c9d/external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/common/MqttUtils.java
----------------------------------------------------------------------
diff --git a/external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/common/MqttUtils.java b/external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/common/MqttUtils.java
index c4bbd11..4ca0145 100644
--- a/external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/common/MqttUtils.java
+++ b/external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/common/MqttUtils.java
@@ -62,7 +62,7 @@ public class MqttUtils {
client.setSslContext(SslUtils.sslContext(uri.getScheme(), keyStoreLoader));
}
client.setClientId(clientId);
- LOG.info("MQTT ClientID: " + client.getClientId().toString());
+ LOG.info("MQTT ClientID: {}", client.getClientId().toString());
client.setCleanSession(options.isCleanConnection());
client.setReconnectDelay(options.getReconnectDelay());
http://git-wip-us.apache.org/repos/asf/storm/blob/d9f09c9d/external/storm-mqtt/core/src/test/java/org/apache/storm/mqtt/StormMqttIntegrationTest.java
----------------------------------------------------------------------
diff --git a/external/storm-mqtt/core/src/test/java/org/apache/storm/mqtt/StormMqttIntegrationTest.java b/external/storm-mqtt/core/src/test/java/org/apache/storm/mqtt/StormMqttIntegrationTest.java
index f07ee6d..43df0ae 100644
--- a/external/storm-mqtt/core/src/test/java/org/apache/storm/mqtt/StormMqttIntegrationTest.java
+++ b/external/storm-mqtt/core/src/test/java/org/apache/storm/mqtt/StormMqttIntegrationTest.java
@@ -103,7 +103,7 @@ public class StormMqttIntegrationTest implements Serializable{
LocalCluster cluster = new LocalCluster();
cluster.submitTopology("test", new Config(), buildMqttTopology());
- System.out.println("topology started");
+ LOG.info("topology started");
while(!spoutActivated) {
Thread.sleep(500);
}
@@ -118,8 +118,8 @@ public class StormMqttIntegrationTest implements Serializable{
LOG.info("published message");
Message message = connection.receive();
- LOG.info("Message recieved on topic: " + message.getTopic());
- LOG.info("Payload: " + new String(message.getPayload()));
+ LOG.info("Message recieved on topic: {}", message.getTopic());
+ LOG.info("Payload: {}", new String(message.getPayload()));
message.ack();
Assert.assertArrayEquals(message.getPayload(), RESULT_PAYLOAD.getBytes());
@@ -138,7 +138,7 @@ public class StormMqttIntegrationTest implements Serializable{
MqttBolt bolt = new MqttBolt(options, new MqttTupleMapper() {
@Override
public MqttMessage toMessage(ITuple tuple) {
- LOG.info("Received: " + tuple);
+ LOG.info("Received: {}", tuple);
return new MqttMessage(RESULT_TOPIC, RESULT_PAYLOAD.getBytes());
}
});