You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/02 04:16:48 UTC

[jira] [Commented] (MESOS-188) declineOffer() should be added to Python-C++ bindings and used in test_framework.py

    [ https://issues.apache.org/jira/browse/MESOS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266297#comment-13266297 ] 

jiraposter@reviews.apache.org commented on MESOS-188:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4960/
-----------------------------------------------------------

Review request for Charles Reiss.


Summary
-------

- This should allow python frameworks to call to call driver.declineOffer().
- Added declineOffer() in test_framework.py example


This addresses bug MESOS-188.
    https://issues.apache.org/jira/browse/MESOS-188


Diffs
-----

  src/examples/python/test_framework.py dd9cf98 
  src/python/native/mesos_scheduler_driver_impl.cpp b8fd16d 

Diff: https://reviews.apache.org/r/4960/diff


Testing
-------


Thanks,

Harvey


                
> declineOffer() should be added to Python-C++ bindings and used in test_framework.py
> -----------------------------------------------------------------------------------
>
>                 Key: MESOS-188
>                 URL: https://issues.apache.org/jira/browse/MESOS-188
>             Project: Mesos
>          Issue Type: Bug
>          Components: python-api
>            Reporter: Harvey Feng 
>            Assignee: Harvey Feng 
>
> Came across this while trying to call driver.declineOffer()
> Traceback (most recent call last):
>   File "./nmpiexec.py", line 76, in resourceOffers
>     driver.declineOffer(offer.id)
> AttributeError: '_mesos.MesosSchedulerDriverImpl' object has no attribute 'declineOffer'
> It should involve a quick fix in src/python/native/mesos_scheduler_diver_imp.cpp
> declineOffer() should also be used in src/examples/python/test_framework.py, which currently holds offers that it should decline if tasksLaunched >= TOTAL_TASKS

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira