You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/29 13:04:38 UTC
[GitHub] [airflow] Milchdealer opened a new issue #8630: Apache Beam 2.20.0 will break the DataFlowOperator
Milchdealer opened a new issue #8630:
URL: https://github.com/apache/airflow/issues/8630
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
This questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**: 1.10.10
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
**Environment**:
- **Cloud provider or hardware configuration**: GCP
- **OS** (e.g. from /etc/os-release): Ubuntu
- **Kernel** (e.g. `uname -a`): 5.0.0-1034-gcp
- **Install tools**: apache-beam (Python) on Google Cloud DataFlow
- **Others**:
**What happened**: When using Apache Beam with Python and upgrading to the latest `apache-beam=2.20.0` version, the DataFlowOperatow will always yield a failed state. The job itself runs fine. The reason is that the Monitoring String Format changed, making the dataflow hook fail retrieving the job_id from GCP.
<!-- (please include exact error messages if you can) -->
**What you expected to happen**: The dataflow job to terminate with no error
<!-- What do you think went wrong? --> The job_id is not retrieved properly since the format changed
**How to reproduce it**: Set up airflow with Dataflow and install apache-beam 2.20.0 for Python. Run a DataFlow job.
<!---
As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
## Install minikube/kind
- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/
If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
You can include images using the .md sytle of
To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
--->
**Anything else we need to know**: The commit that changes the format can be found here: https://github.com/apache/beam/commit/d38e87b6180cb60752be24bdbbb4e17daf0fb3aa
The current regexp in Airflow is `br'.*console.cloud.google.com/dataflow.*/jobs/([a-z|0-9|A-Z|\-|\_]+).*')` and can be found here for 1.10.10: https://github.com/apache/airflow/blob/v1-10-stable/airflow/contrib/hooks/gcp_dataflow_hook.py#L145
As now the `region_id` is coming after `jobs/`, we retrieve the `region_id`.
I got it to work again by using the following regexp: `br".*console.cloud.google.com/dataflow.*/jobs/.*/([a-z|0-9|A-Z|\-|\_]+).*"`
<!--
How often does this problem occur? Once? Every time etc?
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed issue #8630: Apache Beam 2.20.0 will break the DataFlowOperator
Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #8630:
URL: https://github.com/apache/airflow/issues/8630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #8630: Apache Beam 2.20.0 will break the DataFlowOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #8630:
URL: https://github.com/apache/airflow/issues/8630#issuecomment-621190394
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aaltay commented on issue #8630: Apache Beam 2.20.0 will break the DataFlowOperator
Posted by GitBox <gi...@apache.org>.
aaltay commented on issue #8630:
URL: https://github.com/apache/airflow/issues/8630#issuecomment-637154317
As a future improvement, would it be possible to have an integration test using DataFlowOperator and beam head?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #8630: Apache Beam 2.20.0 will break the DataFlowOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8630:
URL: https://github.com/apache/airflow/issues/8630#issuecomment-637157009
I am working on a thorough modernization of integration with Dataflow, so in the next versions Airflow will have better support for this service.
https://github.com/apache/airflow/pulls?q=is%3Apr+is%3Aopen+Dataflow+author%3Amik-laj
I have other changes in the long queue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #8630: Apache Beam 2.20.0 will break the DataFlowOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8630:
URL: https://github.com/apache/airflow/issues/8630#issuecomment-637156099
System tests are run manually, so they would not detect this problem. We hope to add system testing support to CI soon. However, this is not a commercial project, so it is not easy. We need many organizational, technical and financial problems first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org