You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/04 10:37:27 UTC

[GitHub] zentol opened a new pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default

zentol opened a new pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default
URL: https://github.com/apache/flink/pull/6656
 
 
   ## What is the purpose of the change
   
   This PR disables latency tracking by default, and adds a config option for configuring the default latency tracking interval.
   
   The added config option allows users to restore the previous behavior without recompiling all jobs. Job-specific configuration via the `ExecutionConfig` take precedence over the configured value, to ensure that existing jobs that disabled latency tracking continue to do so.
   
   ## Brief change log
   
   * extend `MockEnvironment` to support setting the `TaskManagerRuntimeInfo`
   * split `StreamSourceOperatorTest` into watermark/split parts
   
   * add `MetricOptions#LATENCY_INTERVAL` for configuring the default latency tracking interval
   * set `ExecutionConfig#latencyTrackingInterval` to `MetricOptions.LATENCY_INTERVAL.defaultValue()`
   * add `ExecutionConfig#isLatencyTrackingConfigured` to track whether job-specific settings were applied
   * modify `StreamSource#run` to take configured value into account
   
   * deprecate `ExecutionConfig#isLatencyTrackingEnabled` since it is no longer used, misleading as it doesn't take the configuration into account and requires us to duplicate the interpretation of the interval (i.e. that latency tracking is disabled if it is <= 0)
   
   
   ## Verifying this change
   
   See `StreamSourceOperatorLatencyMetricsTest`. This class is a large extension of the existing `StreamSourceOperatorTest#testLatencyMarkEmission` test (which passed before the refactoring).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services