You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/14 03:59:51 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #36864: [SPARK-39463][CORE][TESTS] Use `UUID` for test database location in `JavaJdbcRDDSuite`
dongjoon-hyun opened a new pull request, #36864:
URL: https://github.com/apache/spark/pull/36864
### What changes were proposed in this pull request?
This PR aims to use UUID instead of a fixed test database location in `JavaJdbcRDDSuite`.
### Why are the changes needed?
Although there exists a clean-up logic in `JavaJdbcRDDSuite`, the location is not removed cleanly when the tests are interrupted. After this PR, we can avoid the conflicts due to the leftover.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36864: [SPARK-39463][CORE][TESTS] Use `UUID` for test database location in `JavaJdbcRDDSuite`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36864:
URL: https://github.com/apache/spark/pull/36864#issuecomment-1154801427
Thank you all. `core` test passed and the SparkR linter failure is irrelevant to this one.
Merged to master/3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36864: [SPARK-39463][CORE][TESTS] Use `UUID` for test database location in `JavaJdbcRDDSuite`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36864:
URL: https://github.com/apache/spark/pull/36864#discussion_r896389409
##########
core/src/test/java/org/apache/spark/JavaJdbcRDDSuite.java:
##########
@@ -32,6 +33,7 @@
import org.junit.Test;
public class JavaJdbcRDDSuite implements Serializable {
+ private String dbName = UUID.randomUUID().toString();
Review Comment:
Oh, thank you. Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36864: [SPARK-39463][CORE][TESTS] Use `UUID` for test database location in `JavaJdbcRDDSuite`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36864:
URL: https://github.com/apache/spark/pull/36864#issuecomment-1154773786
Thank you, @huaxingao .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36864: [SPARK-39463][CORE][TESTS] Use `UUID` for test database location in `JavaJdbcRDDSuite`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36864:
URL: https://github.com/apache/spark/pull/36864#discussion_r896391807
##########
core/src/test/java/org/apache/spark/JavaJdbcRDDSuite.java:
##########
@@ -32,6 +33,7 @@
import org.junit.Test;
public class JavaJdbcRDDSuite implements Serializable {
+ private String dbName = "db_" + UUID.randomUUID().toString().replace('-', '_');
Review Comment:
I borrowed the logic. Thanks, @HyukjinKwon .
https://github.com/apache/spark/blob/2349175e1b81b0a61e1ed90c2d051c01cf78de9b/sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala#L354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36864: [SPARK-39463][CORE][TESTS] Use `UUID` for test database location in `JavaJdbcRDDSuite`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #36864:
URL: https://github.com/apache/spark/pull/36864#discussion_r896378643
##########
core/src/test/java/org/apache/spark/JavaJdbcRDDSuite.java:
##########
@@ -32,6 +33,7 @@
import org.junit.Test;
public class JavaJdbcRDDSuite implements Serializable {
+ private String dbName = UUID.randomUUID().toString();
Review Comment:
I remember it becomes flaky when the UUID starts with numbers (in Spark SQL), e.g.. `SQLTestUtils.withTempDatabase`. Should we better copy and paste that here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #36864: [SPARK-39463][CORE][TESTS] Use `UUID` for test database location in `JavaJdbcRDDSuite`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #36864: [SPARK-39463][CORE][TESTS] Use `UUID` for test database location in `JavaJdbcRDDSuite`
URL: https://github.com/apache/spark/pull/36864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org