[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

["Commit Tag Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610744#comment-13610744 ] 

Commit Tag Bot commented on LUCENE-4425:
----------------------------------------

[branch_4x commit] Robert Muir
http://svn.apache.org/viewvc?view=revision&revision=1390701

LUCENE-4425: Unclear documentation of StoredFieldVisitor.binaryValue

                
> Unclear documentation of StoredFieldVisitor.binaryValue
> -------------------------------------------------------
>
>                 Key: LUCENE-4425
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4425
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Adrien Grand
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4425.patch, LUCENE-4425.patch
>
>
> When reading the binary value of a stored field, a StoredFieldsReader calls StoredFieldVisitor.binaryValue(arr, offset, length).
> Documentation currently doesn't state whether the byte[] can be reused outside of the scope of {{StoredFieldVisitor.binaryValue}} but {{DocumentStoredFieldVisitor}} assumes (as of r1389812) that it can.
> So {{DocumentStoredFieldVisitor}} would break with a custom {{StoredFieldsFormat}} that would call {{StoredFieldVisitor.binaryValue}} with a slice of a reusable buffer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org