[jira] [Commented] (TC-192) Java TM and Go TM get build with exact same RPM Name

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086198#comment-16086198 ] 

ASF GitHub Bot commented on TC-192:
-----------------------------------

GitHub user rguiliani opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/731

    [TC-192] Differentiates between goTM and javaTM rpm builds

    Adds a version differentiator for building goTM and javaTM by including an environment variable in the build service for the golang version (TC_COMPILER), which is utilized by the build/functions.sh script to add "_go" to the version when building the golang version of TM.
    
    Both projects were using the same VERSION file, and since both projects were name the same (traffic_monitor), they produced RPM packages with the same exact name.
    
    Produces two different RPM packages and re-enables the traffic_monitor_golang_build service in the compose file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rguiliani/incubator-trafficcontrol master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/731.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #731
    
----
commit 72d2e068430a8ad6c876168a5f004b60d49a4315
Author: Rossi Guiliani <ro...@guiliani.me>
Date:   2017-07-13T18:37:31Z

    [TC-192] differentiate between goTM and javaTM rpm builds

----


> Java TM and Go TM get build with exact same RPM Name
> ----------------------------------------------------
>
>                 Key: TC-192
>                 URL: https://issues.apache.org/jira/browse/TC-192
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Traffic Monitor, Traffic Monitor (golang)
>    Affects Versions: 2.1.0, 2.0.0
>            Reporter: David Neuman
>              Labels: build, gotm, javatm
>
> When building Traffic Control, goTM and javaTM get build with the exact same rpm name.  This means that if you are building all projects you only get one TM RPM and its whichever one built last.  The names should be updated so that they are not the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)