[jira] [Commented] (AURORA-1897) Remove task length restrictions.

["Zameer Manji (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047016#comment-16047016 ] 

Zameer Manji commented on AURORA-1897:
--------------------------------------

{noformat}
commit 40d9d4dbec86cb4a17e281dc10ede25e83613eff
Author: Zameer Manji <zm...@apache.org>
Date:   Mon Jun 12 13:14:18 2017 -0700

    Remove restriction on task id length.
    
    To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted
    in Mesos task ids longer than 255 characters. This is because Mesos used to use
    the task id to generate the cgroup path. Now Mesos uses it's own id, we no
    longer need to work around this bug.
    
    This removes the restriction in the API layer. This is useful because some users
    may have very long role and service names that caused task ids to go over this
    limit.
    
    Bugs closed: AURORA-1897
    
    Reviewed at https://reviews.apache.org/r/59957/

 .../scheduler/thrift/SchedulerThriftInterface.java | 22 -----
 .../thrift/SchedulerThriftInterfaceTest.java       | 99 ----------------------
 2 files changed, 121 deletions(-)
{noformat}

> Remove task length restrictions.
> --------------------------------
>
>                 Key: AURORA-1897
>                 URL: https://issues.apache.org/jira/browse/AURORA-1897
>             Project: Aurora
>          Issue Type: Task
>            Reporter: Zameer Manji
>            Assignee: Zameer Manji
>            Priority: Minor
>
> Currently we restrict the total name of a task because of a Mesos bug:
> {noformat}
>   // This number is derived from the maximum file name length limit on most UNIX systems, less
>   // the number of characters we've observed being added by mesos for the executor ID, prefix, and
>   // delimiters.
>   @VisibleForTesting
>   static final int MAX_TASK_ID_LENGTH = 255 - 90;
> ....
>     // TODO(maximk): This is a short-term hack to stop the bleeding from
>     //               https://issues.apache.org/jira/browse/MESOS-691
>     if (taskIdGenerator.generate(task, totalInstances).length() > MAX_TASK_ID_LENGTH) {
>       throw new TaskValidationException(
>           "Task ID is too long, please shorten your role or job name.");
>     }
> {noformat} 
> However [~codyg] recently [asked|https://lists.apache.org/thread.html/ca92420fe6394d6467f70989e1ffadac23775e84cf7356ff8c9efdd5@%3Cdev.mesos.apache.org%3E] on the mesos mailing list about MESOS-691 and learned that it is no longer valid.
> We should remove this restriction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)