You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "timtebeek (via GitHub)" <gi...@apache.org> on 2026/04/17 11:23:25 UTC
[PR] Limit YamlDsl413Recipe to Camel YAML DSL files [camel-upgrade-recipes]
timtebeek opened a new pull request, #93:
URL: https://github.com/apache/camel-upgrade-recipes/pull/93
Previously the recipe rewrote kebab-case keys in every YAML file on the classpath, including GitHub Actions workflows, Kubernetes manifests and other unrelated YAML. Add a content-based precondition that only triggers the rewrite when a document's root block contains a known Camel YAML DSL key (route, from, rest, beans, route-configuration, etc.).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit YamlDsl413Recipe to Camel YAML DSL files [camel-upgrade-recipes]
Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #93:
URL: https://github.com/apache/camel-upgrade-recipes/pull/93#issuecomment-4268230484
Great to move quickly here ; as a small note I found this pipeline is no longer allowed:
- https://github.com/apache/camel-upgrade-recipes/actions/workflows/comment-pr.yml
That means it's then probably best to remove these two workflows I'd added earlier
- https://github.com/apache/camel-upgrade-recipes/blob/main/.github/workflows/receive-pr.yml
- https://github.com/apache/camel-upgrade-recipes/blob/main/.github/workflows/comment-pr.yml
These ran the best practices on PRs and added comments with suggested improvements, but without the second there's no sense running the first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit YamlDsl413Recipe to Camel YAML DSL files [camel-upgrade-recipes]
Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #93:
URL: https://github.com/apache/camel-upgrade-recipes/pull/93#issuecomment-4268068724
Thanks for the quick review, and apologies for the failing tests earlier; I was lied to earlier but they should be green now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit YamlDsl413Recipe to Camel YAML DSL files [camel-upgrade-recipes]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #93:
URL: https://github.com/apache/camel-upgrade-recipes/pull/93#issuecomment-4267668603
Thanks for spotting this and helping with the rules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit YamlDsl413Recipe to Camel YAML DSL files [camel-upgrade-recipes]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #93:
URL: https://github.com/apache/camel-upgrade-recipes/pull/93#issuecomment-4267685337
test failure:
'''Error: Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.678 s <<< FAILURE! -- in org.apache.camel.upgrade.springboot.CamelSpringBoot413Test
Error: org.apache.camel.upgrade.springboot.CamelSpringBoot413Test.yamlFile -- Time elapsed: 0.768 s <<< FAILURE!
java.lang.AssertionError:
Expected recipe to complete in 2 cycles, but took 1 cycle. This usually indicates the recipe is making changes after it should have stabilized.
https://docs.openrewrite.org/authoring-recipes/recipe-conventions-and-best-practices#stay-single-cycle
at org.openrewrite.test.LargeSourceSetCheckingExpectedCycles.afterCycle(LargeSourceSetCheckingExpectedCycles.java:121)
at org.openrewrite.RecipeScheduler.runRecipeCycles(RecipeScheduler.java:100)
at org.openrewrite.RecipeScheduler.scheduleRun(RecipeScheduler.java:42)
at org.openrewrite.Recipe.run(Recipe.java:447)
at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:415)
at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:134)
at org.apache.camel.upgrade.springboot.CamelSpringBoot413Test.yamlFile(CamelSpringBoot413Test.java:62)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
'''
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit YamlDsl413Recipe to Camel YAML DSL files [camel-upgrade-recipes]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #93:
URL: https://github.com/apache/camel-upgrade-recipes/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org