[jira] [Commented] (NUTCH-2461) Generate passes the data to when maxCount == 0

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270751#comment-16270751 ] 

ASF GitHub Bot commented on NUTCH-2461:
---------------------------------------

okedoki opened a new pull request #249: fix for NUTCH-2461 generate with maxcount equals 0
URL: https://github.com/apache/nutch/pull/249
 
 
   When max count == 0 the reducer ignores hostdb condition because of  if (maxCount > 0). The fix adds the condition, but add it as explicit statement to save the ruining time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Generate passes the data to when maxCount  == 0
> -----------------------------------------------
>
>                 Key: NUTCH-2461
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2461
>             Project: Nutch
>          Issue Type: Bug
>          Components: generator
>    Affects Versions: 1.14
>            Reporter: Semyon Semyonov
>            Priority: Critical
>             Fix For: 1.14
>
>
> The generator checks condition 
> if (maxCount > 0) : line 421 and stop the generation when amount per host exceeds maxCount( continue : line 455)
> but when  maxCount == 0 it goes directly to line 465 :output.collect(key, entry);
> It is obviously not correct, the correct solution would be to add 
> if(maxCount == 0){
>         	continue;
> }
> at line 380.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)