[GitHub] [skywalking] dmsolr commented on a change in pull request #8761: Support eBPF Profiling E2E

[GitBox <gi...@apache.org>]

dmsolr commented on a change in pull request #8761:
URL: https://github.com/apache/skywalking/pull/8761#discussion_r837364425



##########
File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/query/EBPFProfilingTaskQuery.java
##########
@@ -122,7 +122,7 @@
             task.setProcessName((String) values.get(6));
             task.setTaskStartTime((long) values.get(7));
             task.setTriggerType(EBPFProfilingTriggerType.valueOf((int) values.get(8)));
-            task.setFixedTriggerDuration((long) values.get(9));
+            task.setFixedTriggerDuration(((Number) values.get(9)).longValue());
             task.setTargetType(EBPFProfilingTargetType.valueOf((int) values.get(10)));
             task.setCreateTime((long) values.get(11));
             task.setLastUpdateTime((long) values.get(12));

Review comment:
       I think these types should be unreliable. need to change like Line 125
   pls recheck

##########
File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/query/EBPFProfilingDataQuery.java
##########
@@ -87,7 +87,7 @@
             } else {
                 data.setStacksBinary(new byte[0]);
             }
-            data.setStackDumpCount((Long) values.get(5));
+            data.setStackDumpCount(((Number) values.get(5)).longValue());
             data.setUploadTime((Long) values.get(6));

Review comment:
       this line is also fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org