[GitHub] [hadoop] mukund-thakur commented on pull request #2069: HADOOP-16830. IOStatistics API.

[GitBox <gi...@apache.org>]

mukund-thakur commented on pull request #2069:
URL: https://github.com/apache/hadoop/pull/2069#issuecomment-665455645


   Overall looks good to me. 
   Did a test run on ap-south-1 bucket using  mvn clean verify -Ds3guard -Ddynamo and these failures. Hope these are not related to this change.
   
   `[ERROR] Failures: 
   [ERROR]   ITestS3AMetrics.testStreamStatistics:64->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88 Stream statistics were not merged expected:<26> but was:<0>
   
   [ERROR]   ITestS3AUnbuffer.testUnbufferStreamStatistics:113->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88 Count of stream_read_total_bytes starting=0 current=16 diff=16: stream_read_total_bytes expected:<8> but was:<16>
   
   [ERROR]   ITestS3Select.testSelectOddLinesNoHeader:399->Assert.assertNotEquals:199->Assert.failEquals:185->Assert.fail:88 No bytes read count. Actual: 0
   
   [ERROR]   ITestS3Select.testSelectSeek:346->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88 Seek bytes skipped in StreamStatistics{counters=((stream_aborted=0) (stream_read_close_operations=0) (stream_read_operations=1) (stream_read_bytes=23) (stream_read_bytes_read_in_close=0) (stream_read_version_mismatches=0) (stream_read_seek_backward_operations=0) (stream_read_seek_bytes_read=20) (stream_read_seek_policy_changed=0) (stream_read_seek_operations=1) (stream_read_opened=1) (stream_read_bytes_backwards_on_seek=0) (stream_read_bytes_discarded_in_abort=0) (stream_read_seek_forward_operations=1) (stream_read_total_bytes=43) (stream_read_exceptions=0) (stream_read_bytes_skipped_on_seek=0) (stream_read_operations_incomplete=0) (stream_read_fully_operations=0) (op_http_get_request=0) (stream_read_closed=0)); gauges=((stream_read_gauge_input_policy=0)); minimums=((op_http_get_request.min=9223372036854775807)); maximums=((op_http_get_request.max=0)); means=((op_http_get_
 request.mean=sum=0, samples=0, mean=0.000000)); } expected:<20> but was:<0>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org