[GitHub] [pinot] navina commented on a diff in pull request #10744: Add description field to metrics in Pinot

["navina (via GitHub)" <gi...@apache.org>]

navina commented on code in PR #10744:
URL: https://github.com/apache/pinot/pull/10744#discussion_r1189048094


##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -93,6 +93,10 @@ public PinotMetricsRegistry getMetricsRegistry() {
 
   public interface QueryPhase {
     String getQueryPhaseName();
+
+    default String getDescription() {
+      return "";
+    }

Review Comment:
   technically, it is a public interface. So, we never know who and all have extended this interface to implement their own metrics. So, it is left there for compatibility. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org