You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/30 09:47:59 UTC
[GitHub] [lucene] ChrisHegarty opened a new pull request #337: LUCENE-10118: Expand the log message when CMS.MergeThread completes its merge operation
ChrisHegarty opened a new pull request #337:
URL: https://github.com/apache/lucene/pull/337
# Description
Improve merge thread activity logging.
# Solution
Expand the log message when CMS.MergeThread completes its merge operation, to include addition useful diagnostic information, like the total-bytes-written, the time taken, as well as rate limiter information. Also, while here, unify the thread start and end log output to help improve tracing.
Example log output:
```
merge thread Lucene Merge Thread #0 start
merge thread Lucene Merge Thread #0 merge segment [_2] done estSize=0.0 MB (written=0.0 MB) runTime=0.0s (stopped=0.0s, paused=0.0s) rate=unlimited
merge thread Lucene Merge Thread #0 end
```
# Tests
An additional test scenario, `testMergeThreadMessages`, has been added that exercises and validates the log output.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #337: LUCENE-10118: Expand the log message when CMS.MergeThread completes its merge operation
Posted by GitBox <gi...@apache.org>.
romseygeek merged pull request #337:
URL: https://github.com/apache/lucene/pull/337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org