You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Mikhail Lesyk <go...@lesyk.org> on 2017/08/03 12:51:26 UTC

Review Request 61402: FIX observer themos extra arguments usage

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61402/
-----------------------------------------------------------

Review request for Aurora and Stephan Erb.


Repository: aurora-packaging


Description
-------

arguments variable is specified in /etc/default/thermos file
but is not used in any init script


Diffs
-----

  specs/debian/aurora-executor.thermos.init 8ce391117da9a4ec702b8bec9d2c9fe3b6bbfae9 
  specs/debian/aurora-executor.thermos.service 32fc00434eed21ed394ba0f8c9977c1776477b7c 
  specs/debian/aurora-executor.thermos.upstart 78b11b77bd72d3638270f8220260d306f2d67c43 


Diff: https://reviews.apache.org/r/61402/diff/1/


Testing
-------


Thanks,

Mikhail Lesyk

Re: Review Request 61402: FIX observer themos extra arguments usage

Posted by Stephan Erb <se...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61402/#review182106
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On Aug. 3, 2017, 2:51 p.m., Mikhail Lesyk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61402/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2017, 2:51 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> arguments variable is specified in /etc/default/thermos file
> but is not used in any init script
> 
> 
> Diffs
> -----
> 
>   specs/debian/aurora-executor.thermos.init 8ce391117da9a4ec702b8bec9d2c9fe3b6bbfae9 
>   specs/debian/aurora-executor.thermos.service 32fc00434eed21ed394ba0f8c9977c1776477b7c 
>   specs/debian/aurora-executor.thermos.upstart 78b11b77bd72d3638270f8220260d306f2d67c43 
> 
> 
> Diff: https://reviews.apache.org/r/61402/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mikhail Lesyk
> 
>