You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Aakcht (via GitHub)" <gi...@apache.org> on 2023/06/23 15:22:55 UTC
[GitHub] [airflow] Aakcht opened a new pull request, #32100: Chart: template dagprocessor waitformigrations extraVolumeMounts
Aakcht opened a new pull request, #32100:
URL: https://github.com/apache/airflow/pull/32100
Looks like #30990 got a bit mixed up with #30773 and the extraVolumeMounts of dagprocessor wait for migrations init container are not templated, while other extraVolumeMounts are templated.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32100: Chart: template dagprocessor waitformigrations extraVolumeMounts
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32100:
URL: https://github.com/apache/airflow/pull/32100#issuecomment-1610231438
WDYT @hussein-awala @jedcunningham ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #32100: Chart: template dagprocessor waitformigrations extraVolumeMounts
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #32100:
URL: https://github.com/apache/airflow/pull/32100#issuecomment-1605578952
Can you add test coverage for this as well? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32100: Chart: template dagprocessor waitformigrations extraVolumeMounts
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32100:
URL: https://github.com/apache/airflow/pull/32100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aakcht commented on pull request #32100: Chart: template dagprocessor waitformigrations extraVolumeMounts
Posted by "Aakcht (via GitHub)" <gi...@apache.org>.
Aakcht commented on PR #32100:
URL: https://github.com/apache/airflow/pull/32100#issuecomment-1605673580
@jedcunningham, I added the tests, please take a look. Looks like the failing check is not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aakcht commented on pull request #32100: Chart: template dagprocessor waitformigrations extraVolumeMounts
Posted by "Aakcht (via GitHub)" <gi...@apache.org>.
Aakcht commented on PR #32100:
URL: https://github.com/apache/airflow/pull/32100#issuecomment-1607638404
I'd say updates on chart tests are somewhat related to this change - I just modified the tests so they would test templating of extraVolumeMounts/extraVolumes for all components, not just for dagProcessor. But if you do think it would be better to separate the changes, please tell me - I'll move changes not related to dag-processor to a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32100: Chart: template dagprocessor waitformigrations extraVolumeMounts
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32100:
URL: https://github.com/apache/airflow/pull/32100#issuecomment-1610231240
> I'd say updates on chart tests are somewhat related to this change
Yeah. Those tests changes seem related, I ofen use opportunities like that to generally improve test code. Seems that thos test change still test what they were supposed to test (but better) and there is no functional change to the airflow code, so very little risk with having them in single PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org