You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2014/06/23 18:22:38 UTC

git commit: TAP5-2133: DefaultRequestExceptionHandler swallows exceptions

Repository: tapestry-5
Updated Branches:
  refs/heads/master 581f50808 -> 24344bed9


TAP5-2133: DefaultRequestExceptionHandler swallows exceptions


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/24344bed
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/24344bed
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/24344bed

Branch: refs/heads/master
Commit: 24344bed915715a5c2424edfeab9bbb5f12f7089
Parents: 581f508
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jun 23 09:22:41 2014 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jun 23 09:22:41 2014 -0700

----------------------------------------------------------------------
 .../internal/services/DefaultRequestExceptionHandler.java          | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/24344bed/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DefaultRequestExceptionHandler.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DefaultRequestExceptionHandler.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DefaultRequestExceptionHandler.java
index 4ae362c..2e69878 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DefaultRequestExceptionHandler.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DefaultRequestExceptionHandler.java
@@ -223,6 +223,8 @@ public class DefaultRequestExceptionHandler implements RequestExceptionHandler
         // user's responsibility not to abuse the mechanism
         catch (Exception e)
         {
+            logger.warn(String.format("A new exception was thrown while trying to handle an instance of %s.",
+                    exception.getClass().getName()), e);
             // Nothing to do but delegate
             renderException(exception);
         }