[jira] [Issue Comment Deleted] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler

["Dapeng Sun (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dapeng Sun updated SENTRY-996:
------------------------------
    Comment: was deleted

(was: Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12806107/SENTRY-996.001.patch against master.

{color:red}Overall:{color} -1 due to 2 errors

{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed: org.apache.sentry.provider.db.generic.service.persistent.TestPrivilegeOperatePersistence

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/1648/console

This message is automatically generated.)

> Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler 
> -------------------------------------------------------------------------------
>
>                 Key: SENTRY-996
>                 URL: https://issues.apache.org/jira/browse/SENTRY-996
>             Project: Sentry
>          Issue Type: Bug
>            Reporter: Colm O hEigeartaigh
>            Assignee: Ke Jia
>         Attachments: SENTRY-996-002.patch, SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a while(true) loop that looks like it was designed to catch certain exceptions + retry. However, the logic is faulty in that it will always return after the first iteration, not matter what (as picked up by PMD).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)