You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/10 10:17:07 UTC

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #15761: [fix][client] Remove consumer when close consumer command is received

codelipenghui commented on code in PR #15761:
URL: https://github.com/apache/pulsar/pull/15761#discussion_r894376775


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -115,6 +115,7 @@ public class ClientCnx extends PulsarHandler {
                     .expectedItems(16)
                     .concurrencyLevel(1)
                     .build();
+    @Getter

Review Comment:
   It's better to return an immutable map to prevent anyone to modify it externally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org