You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/09/19 18:27:49 UTC

[GitHub] [commons-bcel] mernst opened a new pull request, #146: (doc) Document who owns a resource

mernst opened a new pull request, #146:
URL: https://github.com/apache/commons-bcel/pull/146

   Complementing https://github.com/apache/commons-bcel/pull/138, this pull request indicates who is responsible for closing a resource.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-bcel] mernst closed pull request #146: (doc) Document who owns a resource

Posted by GitBox <gi...@apache.org>.

mernst closed pull request #146: (doc) Document who owns a resource
URL: https://github.com/apache/commons-bcel/pull/146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #146: (doc) Document who owns a resource

Posted by GitBox <gi...@apache.org>.

garydgregory commented on code in PR #146:
URL: https://github.com/apache/commons-bcel/pull/146#discussion_r974756058


##########
src/main/java/org/apache/bcel/classfile/ClassParser.java:
##########
@@ -59,7 +59,7 @@ public final class ClassParser {
     /**
      * Parses class from the given stream.
      *
-     * @param inputStream Input stream
+     * @param inputStream Input stream; the client should close it

Review Comment:
   -1: No need to say this IMO, it should be a basic best practice that the allocation site is the closing site. Only the opposite should be documented.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org