You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/29 14:52:10 UTC
[GitHub] [arrow-rs] bphillips-exos opened a new pull request, #2225: Add append_option support to decimal builders
bphillips-exos opened a new pull request, #2225:
URL: https://github.com/apache/arrow-rs/pull/2225
# Which issue does this PR close?
Closes #2224
# Rationale for this change
Most of the other builders support append_option which is quite useful for optional fields.
# What changes are included in this PR?
Support for append_option in `Decimal128Builder` and `Decimal256Builder`.
# Are there any user-facing changes?
One new public method on `Decimal128Builder` and `Decimal256Builder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] bphillips-exos commented on pull request #2225: Add append_option support to decimal builders
Posted by GitBox <gi...@apache.org>.
bphillips-exos commented on PR #2225:
URL: https://github.com/apache/arrow-rs/pull/2225#issuecomment-1199695047
Thanks, should be fixed now @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #2225: Add append_option support to decimal builders
Posted by GitBox <gi...@apache.org>.
viirya merged PR #2225:
URL: https://github.com/apache/arrow-rs/pull/2225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2225: Add append_option support to decimal builders
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2225:
URL: https://github.com/apache/arrow-rs/pull/2225#issuecomment-1199569382
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2225?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2225](https://codecov.io/gh/apache/arrow-rs/pull/2225?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5e0bb8) into [master](https://codecov.io/gh/apache/arrow-rs/commit/588f40889f5970de66cce855e71a65fc098a4691?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (588f408) will **increase** coverage by `0.00%`.
> The diff coverage is `90.00%`.
> :exclamation: Current head b5e0bb8 differs from pull request most recent head 915c9d4. Consider uploading reports for the commit 915c9d4 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2225 +/- ##
=======================================
Coverage 82.52% 82.52%
=======================================
Files 240 240
Lines 62267 62283 +16
=======================================
+ Hits 51387 51401 +14
- Misses 10880 10882 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/builder/decimal\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2225/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvZGVjaW1hbF9idWlsZGVyLnJz) | `86.27% <90.00%> (+0.14%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2225: Add append_option support to decimal builders
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2225:
URL: https://github.com/apache/arrow-rs/pull/2225#issuecomment-1199548517
There appear to be lint failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #2225: Add append_option support to decimal builders
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #2225:
URL: https://github.com/apache/arrow-rs/pull/2225#discussion_r933479387
##########
arrow/src/array/builder/decimal_builder.rs:
##########
@@ -117,6 +117,18 @@ impl Decimal128Builder {
self.builder.append_null()
}
+ /// Appends an `Option<T>` into the builder.
Review Comment:
```suggestion
/// Appends an `Option<impl Into<i128>>` into the builder.
```
##########
arrow/src/array/builder/decimal_builder.rs:
##########
@@ -219,6 +231,18 @@ impl Decimal256Builder {
self.builder.append_null()
}
+ /// Appends an `Option<T>` into the builder.
Review Comment:
```suggestion
/// Appends an `Option<&Decimal256>` into the builder.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2225: Add append_option support to decimal builders
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2225:
URL: https://github.com/apache/arrow-rs/pull/2225#issuecomment-1199931403
Benchmark runs are scheduled for baseline = 41d96b21628a9035623b72e80d7ea06e5fb904f9 and contender = 561b14c64ead1534618daeb89e32b68fddbc7f3b. 561b14c64ead1534618daeb89e32b68fddbc7f3b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/09f8a04f0f59426f84f6f98126c50f14...0e6d9db7a09e4bf8b335c08b741e9c56/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8a67d965aea543649ea13c07f5c169e6...ef69d09f55514090991c381652befd1b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/49d95c88c79a42cea38b7263af687e15...5ac59a1be31e436bad0c9fc97382d873/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b306f3eb08944713950ef01e0b060f7a...936415e45e9e4a98af4ee35d130e6cb0/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org