You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/15 19:57:00 UTC
[jira] [Commented] (PROTON-2194) Incorrect memory deallocation
[ https://issues.apache.org/jira/browse/PROTON-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084347#comment-17084347 ]
ASF GitHub Bot commented on PROTON-2194:
----------------------------------------
attila-kun commented on pull request #240: [PROTON-2194] Incorrect memory deallocation fix
URL: https://github.com/apache/qpid-proton/pull/240
When execution gets to `server_name_matches` in `schannel.c`, an attempt is made to deallocate a chunk of memory here: https://github.com/apache/qpid-proton/blob/0.30.0/c/src/ssl/schannel.c#L2078
However, this is incorrect because the code is passing the pointer's address (which is a memory location on the stack, not the heap) to LocalFree . This causes a crash. The fix is simply to pass the pointer's value: https://github.com/attila-kun/qpid-proton/commit/21e88fe0b18a4587768b16ae275a8ae88fd919bb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Incorrect memory deallocation
> -----------------------------
>
> Key: PROTON-2194
> URL: https://issues.apache.org/jira/browse/PROTON-2194
> Project: Qpid Proton
> Issue Type: Bug
> Reporter: Attila Kun
> Priority: Major
> Attachments: schannel_exception.png
>
>
> When execution gets to {{server_name_matches}} in {{schannel.c}}, an attempt is made to deallocate a chunk of memory here: [https://github.com/apache/qpid-proton/blob/0.30.0/c/src/ssl/schannel.c#L2078]
> However, this is incorrect because the code is passing the pointer's address (which is a memory location on the stack, not the heap) to {{LocalFree}} . This causes a crash. The fix is simply to pass the pointer's value: [https://github.com/attila-kun/qpid-proton/commit/21e88fe0b18a4587768b16ae275a8ae88fd919bb]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org