You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/05/27 17:09:19 UTC
Review Request 34712: ambari-agent.out file grows geometrically and
quickly fills up disk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34712/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-11349
https://issues.apache.org/jira/browse/AMBARI-11349
Repository: ambari
Description
-------
See attached files. This came from a devdeploy test where some service check
was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not
the reason but was the largest contributor.
Can you check if we can avoid logging to the out file unless there was an
error due to which this is expected?
If out file does not roll this could be an issue in the long run.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 969a01f
Diff: https://reviews.apache.org/r/34712/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 34712: ambari-agent.out file grows geometrically
and quickly fills up disk
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On May 27, 2015, 3:11 p.m., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py, lines 102-103
> > <https://reviews.apache.org/r/34712/diff/1/?file=972686#file972686line102>
> >
> > Why is this logger only set if there's a match for the scripts basedir; shouldn't the initialization of the ScriptAlert class do this in general?
this is resource_manamgement logger. Resource management is invalid without Environment. It does not make any sense to alter that logger when we don't have Environment
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34712/#review85376
-----------------------------------------------------------
On May 27, 2015, 3:09 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34712/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 3:09 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-11349
> https://issues.apache.org/jira/browse/AMBARI-11349
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See attached files. This came from a devdeploy test where some service check
> was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not
> the reason but was the largest contributor.
>
> Can you check if we can avoid logging to the out file unless there was an
> error due to which this is expected?
>
> If out file does not roll this could be an issue in the long run.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 969a01f
>
> Diff: https://reviews.apache.org/r/34712/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 34712: ambari-agent.out file grows geometrically
and quickly fills up disk
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34712/#review85376
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py
<https://reviews.apache.org/r/34712/#comment136919>
Why is this logger only set if there's a match for the scripts basedir; shouldn't the initialization of the ScriptAlert class do this in general?
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py
<https://reviews.apache.org/r/34712/#comment136917>
Remove print statement
- Jonathan Hurley
On May 27, 2015, 11:09 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34712/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 11:09 a.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-11349
> https://issues.apache.org/jira/browse/AMBARI-11349
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See attached files. This came from a devdeploy test where some service check
> was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not
> the reason but was the largest contributor.
>
> Can you check if we can avoid logging to the out file unless there was an
> error due to which this is expected?
>
> If out file does not roll this could be an issue in the long run.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 969a01f
>
> Diff: https://reviews.apache.org/r/34712/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 34712: ambari-agent.out file grows geometrically
and quickly fills up disk
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34712/#review85377
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Травень 27, 2015, 3:09 після полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34712/
> -----------------------------------------------------------
>
> (Updated Травень 27, 2015, 3:09 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-11349
> https://issues.apache.org/jira/browse/AMBARI-11349
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See attached files. This came from a devdeploy test where some service check
> was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not
> the reason but was the largest contributor.
>
> Can you check if we can avoid logging to the out file unless there was an
> error due to which this is expected?
>
> If out file does not roll this could be an issue in the long run.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 969a01f
>
> Diff: https://reviews.apache.org/r/34712/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 34712: ambari-agent.out file grows geometrically
and quickly fills up disk
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34712/#review85379
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Травень 27, 2015, 3:21 після полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34712/
> -----------------------------------------------------------
>
> (Updated Травень 27, 2015, 3:21 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-11349
> https://issues.apache.org/jira/browse/AMBARI-11349
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See attached files. This came from a devdeploy test where some service check
> was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not
> the reason but was the largest contributor.
>
> Can you check if we can avoid logging to the out file unless there was an
> error due to which this is expected?
>
> If out file does not roll this could be an issue in the long run.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 969a01f
>
> Diff: https://reviews.apache.org/r/34712/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 34712: ambari-agent.out file grows geometrically
and quickly fills up disk
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34712/
-----------------------------------------------------------
(Updated May 27, 2015, 3:21 p.m.)
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-11349
https://issues.apache.org/jira/browse/AMBARI-11349
Repository: ambari
Description
-------
See attached files. This came from a devdeploy test where some service check
was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not
the reason but was the largest contributor.
Can you check if we can avoid logging to the out file unless there was an
error due to which this is expected?
If out file does not roll this could be an issue in the long run.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 969a01f
Diff: https://reviews.apache.org/r/34712/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk