You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/10 03:51:26 UTC

[GitHub] [spark] sumeetgajjar edited a comment on pull request #32114: [Spark 35011][CORE] Avoid Block Manager registerations when StopExecutor msg is in-flight

sumeetgajjar edited a comment on pull request #32114:
URL: https://github.com/apache/spark/pull/32114#issuecomment-817025778


   It turns out "on-disk storage" (`encryptionTest`) under `BlockManagerSuite` fails when "encryption = on" on my mac. But Intellij does not report it as a failure since the jvm simply exited. It also does not run the next set of tests under `BlockManagerSuite` given such scenarios and hence I didn't notice NPE for two of those unrunned tests. 
   
   However, the same encryption test passes on Github. JVM exits while dynamically loading `org.apache.commons.crypto.random.OpenSslCryptoRandom` using `commons-crypto` on my machine.
   
   Lesson learnt: always perform a final sanity test run using `sbt/mvn` before concluding the test passes 😋 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org