You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/24 08:00:56 UTC

[GitHub] [cloudstack] wido commented on a diff in pull request #5862: KVM HA Enhancements for Ceph RBD Primary Storage

wido commented on code in PR #5862:
URL: https://github.com/apache/cloudstack/pull/5862#discussion_r1031157844


##########
scripts/vm/hypervisor/kvm/kvmvmactivity_rbd.py:
##########
@@ -0,0 +1,103 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   Same goes here. Interpreter needed here?



##########
scripts/vm/hypervisor/kvm/kvmheartbeat_rbd.py:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   Shouldn't we add the interpreter here? For example: /usr/bin/env python3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org