You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/13 11:26:06 UTC

[GitHub] [spark] MaxGekk opened a new pull request #28205: [WIP][SQL] Fix perf regression of fromJavaDate

MaxGekk opened a new pull request #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205
 
 
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   Spark 2.4.6:
   ```
   OpenJDK 64-Bit Server VM 1.8.0_242-8u242-b08-0ubuntu3~18.04-b08 on Linux 4.15.0-1063-aws
   Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
   To/from java.sql.Timestamp:               Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   ------------------------------------------------------------------------------------------------------------------------
   From java.sql.Date                                  614            655          43          8.1         122.8       1.0X
   ```
   
   Before the changes:
   ```
   OpenJDK 64-Bit Server VM 1.8.0_242-8u242-b08-0ubuntu3~18.04-b08 on Linux 4.15.0-1063-aws
   Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
   To/from java.sql.Timestamp:               Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   ------------------------------------------------------------------------------------------------------------------------
   From java.sql.Date                                 1154           1206          46          4.3         230.9       1.0X
   ```
   
   After:
   ```
   OpenJDK 64-Bit Server VM 1.8.0_242-8u242-b08-0ubuntu3~18.04-b08 on Linux 4.15.0-1063-aws
   Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
   To/from java.sql.Timestamp:               Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   ------------------------------------------------------------------------------------------------------------------------
   From java.sql.Date                                  427            434           7         11.7          85.3       1.0X
   ```
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613277927
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25948/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613319680
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613325737
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25953/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612986658
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121204/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613227589
 
 
   can we fix the conflicts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613154087
 
 
   **[Test build #121219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121219/testReport)** for PR 28205 at commit [`bc8110b`](https://github.com/apache/spark/commit/bc8110be93a7912b364189f1c613cf75f19d027e).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613045956
 
 
   **[Test build #121219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121219/testReport)** for PR 28205 at commit [`bc8110b`](https://github.com/apache/spark/commit/bc8110be93a7912b364189f1c613cf75f19d027e).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613154717
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121219/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613046454
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25907/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613325737
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25953/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613482864
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121266/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612986648
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613154709
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613046441
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612863677
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613325731
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#discussion_r407905485
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ##########
 @@ -101,16 +101,10 @@ object DateTimeUtils {
    * @return The number of days since epoch from java.sql.Date.
    */
   def fromJavaDate(date: Date): SQLDate = {
-    val era = if (date.before(julianCommonEraStart)) 0 else 1
-    val localDate = LocalDate
-      .of(date.getYear + 1900, date.getMonth + 1, 1)
-      .`with`(ChronoField.ERA, era)
-      // Add days separately to convert dates existed in Julian calendar but not
-      // in Proleptic Gregorian calendar. For example, 1000-02-29 is valid date
-      // in Julian calendar because 1000 is a leap year but 1000 is not a leap
-      // year in Proleptic Gregorian calendar. And 1000-02-29 doesn't exist in it.
-      .plusDays(date.getDate - 1) // Returns the next valid date after `date.getDate - 1` days
-    localDateToDays(localDate)
+    val millisUtc = date.getTime
+    val millisLocal = millisUtc + TimeZone.getDefault.getOffset(millisUtc)
+    val julianDays = Math.toIntExact(Math.floorDiv(millisLocal, MILLIS_PER_DAY))
 
 Review comment:
   @cloud-fan Spark 2.4 uses floating point ops, see https://github.com/apache/spark/blob/branch-2.4/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala#L137

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612863682
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25892/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612861411
 
 
   @cloud-fan FYI

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613277332
 
 
   **[Test build #121261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121261/testReport)** for PR 28205 at commit [`ee1d788`](https://github.com/apache/spark/commit/ee1d78865069e3beb2192f5b360af0df63e5d1ea).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613046454
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25907/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613325731
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613046441
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613325003
 
 
   **[Test build #121266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121266/testReport)** for PR 28205 at commit [`ee1d788`](https://github.com/apache/spark/commit/ee1d78865069e3beb2192f5b360af0df63e5d1ea).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613319509
 
 
   **[Test build #121261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121261/testReport)** for PR 28205 at commit [`ee1d788`](https://github.com/apache/spark/commit/ee1d78865069e3beb2192f5b360af0df63e5d1ea).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613319680
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613325003
 
 
   **[Test build #121266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121266/testReport)** for PR 28205 at commit [`ee1d788`](https://github.com/apache/spark/commit/ee1d78865069e3beb2192f5b360af0df63e5d1ea).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613410832
 
 
   +1. Looks good to me too from a cursory look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613277915
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612863682
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25892/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613484924
 
 
   thanks, merging to master/3.0!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613482847
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613277332
 
 
   **[Test build #121261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121261/testReport)** for PR 28205 at commit [`ee1d788`](https://github.com/apache/spark/commit/ee1d78865069e3beb2192f5b360af0df63e5d1ea).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613277915
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612863677
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613482864
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121266/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612986658
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121204/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613222161
 
 
   @cloud-fan @HyukjinKwon Please, review the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612863292
 
 
   **[Test build #121204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121204/testReport)** for PR 28205 at commit [`b174c1a`](https://github.com/apache/spark/commit/b174c1a23df95b9d93f36e43963a22fe1b885668).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612986648
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613482847
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613323610
 
 
   jenkins, retest this, please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613154717
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121219/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613045956
 
 
   **[Test build #121219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121219/testReport)** for PR 28205 at commit [`bc8110b`](https://github.com/apache/spark/commit/bc8110be93a7912b364189f1c613cf75f19d027e).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613154709
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613277927
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25948/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613481525
 
 
   **[Test build #121266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121266/testReport)** for PR 28205 at commit [`ee1d788`](https://github.com/apache/spark/commit/ee1d78865069e3beb2192f5b360af0df63e5d1ea).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613319694
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121261/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612863292
 
 
   **[Test build #121204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121204/testReport)** for PR 28205 at commit [`b174c1a`](https://github.com/apache/spark/commit/b174c1a23df95b9d93f36e43963a22fe1b885668).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28205: [WIP][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-612985764
 
 
   **[Test build #121204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121204/testReport)** for PR 28205 at commit [`b174c1a`](https://github.com/apache/spark/commit/b174c1a23df95b9d93f36e43963a22fe1b885668).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28205: [SPARK-31439][SQL] Fix perf regression of fromJavaDate
URL: https://github.com/apache/spark/pull/28205#issuecomment-613319694
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121261/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org