Re: [PR] ARTEMIS-5753 Mitigation of a PageCompletion possible race condition [activemq-artemis]

["jbertram (via GitHub)" <gi...@apache.org>]

jbertram commented on code in PR #6037:
URL: https://github.com/apache/activemq-artemis/pull/6037#discussion_r2511202327


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/SimpleManagement.java:
##########
@@ -101,8 +101,15 @@ public long getCurrentTimeMillis() throws Exception {
       return simpleManagementLong("broker", "getCurrentTimeMillis");
    }
 
-   public boolean isReplicaSync() throws Exception {
-      return simpleManagementBoolean("broker", "isReplicaSync");
+   public boolean isReplicaSync() {
+      try {
+         return simpleManagementBoolean("broker", "isReplicaSync");
+      } catch (Throwable e) {
+         // in case of a failure we return false..
+         // so the caller may keep retrying until it's true
+         logger.warn(e.getMessage(), e);
+         return false;

Review Comment:
   Technically speaking I think should use a new logging method + code in `ActiveMQClientLogger`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact