You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by hbdeshmukh <gi...@git.apache.org> on 2016/08/08 17:23:51 UTC

[GitHub] incubator-quickstep pull request #84: Added guards for gnu_source definition...

GitHub user hbdeshmukh opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/84

    Added guards for gnu_source definition in storage CMakeLists

    Background: We use mmap to allocate memory whenever it is available. There is a check in storage module's CMakeLists to further check if mmap can support HugePage allocation. 
    
    Issue: The check for HugePage allocation used the definition for ``GNU_SOURCE`` macro. Some compilers by default have this macro defined, which causes the compiler to throw a warning "macro already defined". As warnings are treated as errors, this check fails, therefore CMake declares that HugePage support is not available. 
    
    Fix: Guard the definition by #ifndef directive.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep hugetlb-check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit d2256e778dc1adec8098336aaf675d7d2058bef9
Author: Harshad Deshmukh <hb...@apache.org>
Date:   2016-08-08T17:19:00Z

    Added guards for gnu_source definition in CMake.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #84: Added guards for gnu_source definition...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/84


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #84: Added guards for gnu_source definition in sto...

Posted by zuyu <gi...@git.apache.org>.

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/84
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---