You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/02/21 16:07:16 UTC

[GitHub] dubee commented on a change in pull request #319: Do not fire trigger with invalid JSON

dubee commented on a change in pull request #319: Do not fire trigger with invalid JSON
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/319#discussion_r258997620
 
 

 ##########
 File path: provider/consumer.py
 ##########
 @@ -485,7 +485,7 @@ def __encodeMessageIfNeeded(self, value):
 
         if self.encodeValueAsJSON:
             try:
-                parsed = json.loads(value)
+                parsed = json.loads(value, parse_constant=self.__errorOnJSONConstant)
 
 Review comment:
   The `json.dumps` call needs to be able to read JSON constants to get an accurate message size value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services