You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2014/10/20 20:45:11 UTC
Review Request 26949: Config history: comparing two versions with
removed properties shows 'Undefined' on HDP-2.1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26949/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
Bugs: AMBARI-7873
https://issues.apache.org/jira/browse/AMBARI-7873
Repository: ambari
Description
-------
Add some custom property with value, save.
Remove this property, save.
Click V2.
Then point to V1 and click compare.
both properties have undefined value
Diffs
-----
ambari-web/app/controllers/main/service/info/configs.js d986fa3
ambari-web/app/messages.js df69e77
ambari-web/app/templates/common/configs/compare_property.hbs 3e6ddbe
ambari-web/test/controllers/main/service/info/config_test.js e2cf89b
Diff: https://reviews.apache.org/r/26949/diff/
Testing
-------
tests added
4520 tests complete (6 seconds)
60 tests pending
Thanks,
Andriy Babiichuk
Re: Review Request 26949: Config history: comparing two versions with
removed properties shows 'Undefined' on HDP-2.1
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26949/#review57561
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 20, 2014, 6:45 після полудня, Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26949/
> -----------------------------------------------------------
>
> (Updated Жов. 20, 2014, 6:45 після полудня)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
>
>
> Bugs: AMBARI-7873
> https://issues.apache.org/jira/browse/AMBARI-7873
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add some custom property with value, save.
> Remove this property, save.
> Click V2.
> Then point to V1 and click compare.
> both properties have undefined value
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js d986fa3
> ambari-web/app/messages.js df69e77
> ambari-web/app/templates/common/configs/compare_property.hbs 3e6ddbe
> ambari-web/test/controllers/main/service/info/config_test.js e2cf89b
>
> Diff: https://reviews.apache.org/r/26949/diff/
>
>
> Testing
> -------
>
> tests added
> 4520 tests complete (6 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>
Re: Review Request 26949: Config history: comparing two versions with
removed properties shows 'Undefined' on HDP-2.1
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26949/#review57562
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Окт. 20, 2014, 6:45 п.п., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26949/
> -----------------------------------------------------------
>
> (Updated Окт. 20, 2014, 6:45 п.п.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
>
>
> Bugs: AMBARI-7873
> https://issues.apache.org/jira/browse/AMBARI-7873
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add some custom property with value, save.
> Remove this property, save.
> Click V2.
> Then point to V1 and click compare.
> both properties have undefined value
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js d986fa3
> ambari-web/app/messages.js df69e77
> ambari-web/app/templates/common/configs/compare_property.hbs 3e6ddbe
> ambari-web/test/controllers/main/service/info/config_test.js e2cf89b
>
> Diff: https://reviews.apache.org/r/26949/diff/
>
>
> Testing
> -------
>
> tests added
> 4520 tests complete (6 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>
Re: Review Request 26949: Config history: comparing two versions with
removed properties shows 'Undefined' on HDP-2.1
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26949/#review57560
-----------------------------------------------------------
Ship it!
Ship It!
- Oleg Nechiporenko
On Oct. 20, 2014, 6:45 p.m., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26949/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 6:45 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
>
>
> Bugs: AMBARI-7873
> https://issues.apache.org/jira/browse/AMBARI-7873
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add some custom property with value, save.
> Remove this property, save.
> Click V2.
> Then point to V1 and click compare.
> both properties have undefined value
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js d986fa3
> ambari-web/app/messages.js df69e77
> ambari-web/app/templates/common/configs/compare_property.hbs 3e6ddbe
> ambari-web/test/controllers/main/service/info/config_test.js e2cf89b
>
> Diff: https://reviews.apache.org/r/26949/diff/
>
>
> Testing
> -------
>
> tests added
> 4520 tests complete (6 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>