[jira] [Commented] (ARROW-8486) [C++] arrow-utility-test causes failures on a big-endian platform

["Kazuaki Ishizaki (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086720#comment-17086720 ] 

Kazuaki Ishizaki commented on ARROW-8486:
-----------------------------------------

[~apitrou] Could you give me your advice?
I am working for addressing an issue described in  ARROW-4018. The below your suggested code works well for primitive types.   

On the other hand, I enable `-DARROW_PARQUET=ON` in cmake, non-primitive types (parquet::FixedLenByteArray, parquet::ByteArray, and parquet::Int96) are passed as T. In this case, this line `current_value_ = static_cast<uint64_t>(value)` causes the cast error.   
IMHO, these cases use 32 as bit_width_ (just my guess, I did not confirm it). Am I correct?

While I tried to create a patch by using std::enable_if or constexpr, I was not successful to create it. Are there any advices to handle these three cases?


{code}
    T value = T();
    bool result =
        bit_reader_.GetAligned<T>(static_cast<int>(BitUtil::CeilDiv(bit_width_, 8)), &value);
    current_value_ = static_cast<uint64_t>(value);
{code}

> [C++] arrow-utility-test causes failures on a big-endian platform
> -----------------------------------------------------------------
>
>                 Key: ARROW-8486
>                 URL: https://issues.apache.org/jira/browse/ARROW-8486
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Kazuaki Ishizaki
>            Priority: Minor
>
> The current master causes the following failures in arrow-util-test.
> {code}
> Start 17: arrow-utility-test
>  ...
>  17: [ PASSED ] 253 tests.
>  17: [ FAILED ] 11 tests, listed below:
>  17: [ FAILED ] Bitmap.ShiftingWordsOptimization
>  17: [ FAILED ] Bitmap.VisitWordsAnd
>  17: [ FAILED ] BitArray.TestBool
>  17: [ FAILED ] BitArray.TestValues
>  17: [ FAILED ] Rle.SpecificSequences
>  17: [ FAILED ] Rle.TestValues
>  17: [ FAILED ] BitRle.Flush
>  17: [ FAILED ] BitRle.Random
>  17: [ FAILED ] BitRle.RepeatedPattern
>  17: [ FAILED ] BitRle.Overflow
>  17: [ FAILED ] RleDecoder.GetBatchSpaced
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)