You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/06/04 08:00:48 UTC
[GitHub] [thrift] phile314 opened a new pull request #2170: THRIFT-5227: Update haskell build to cabal v2-* commands
phile314 opened a new pull request #2170:
URL: https://github.com/apache/thrift/pull/2170
<!-- Explain the changes in the pull request below: -->
Fixes the build with recent cabal versions.
I am not a cmake expert, so I just tried to get it working ...
If I do `cmake && make check` the tests pass. I do not seem to be able to call `make cross`, that target does not exist?
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #2170: THRIFT-5227: Update haskell build to cabal v2-* commands
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2170:
URL: https://github.com/apache/thrift/pull/2170#issuecomment-670813121
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #2170: THRIFT-5227: Update haskell build to cabal v2-* commands
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2170:
URL: https://github.com/apache/thrift/pull/2170#issuecomment-674344762
This issue has been automatically closed due to inactivity. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] closed pull request #2170: THRIFT-5227: Update haskell build to cabal v2-* commands
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #2170:
URL: https://github.com/apache/thrift/pull/2170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org