You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by Michael Dürig <md...@apache.org> on 2014/07/08 17:52:53 UTC
NodeType information in observation events
Hi,
Often it would be helpful if observation events would carry node type
information. In Oak we added some initial support for this [1] by adding
the node type and the mixin types of the associated node of an event to
the info map.
In JCR-3765 [2] I suggested to backport this functionality to
Jackrabbit. However this will cause the GetInfoTest TCK test to fail.
That test asserts that the info map is empty for all non move events.
What do people think about adapting the test expectations of this test
and allow for said entries?
Michael
[1] https://issues.apache.org/jira/browse/OAK-1661
[2] https://issues.apache.org/jira/browse/JCR-3765
Re: NodeType information in observation events
Posted by Michael Dürig <md...@apache.org>.
Good point. I created https://java.net/jira/browse/JSR_333-75
Michael
On 9.7.14 8:48 , Marcel Reutegger wrote:
> Hi,
>
> we probably have the TCK test in place because the spec explicitly
> says the map is empty in those cases. see 12.3.2 Event Information.
> on the other hand, I don't see a reason why an implementation shouldn't
> be allowed to pass more information than required.
>
> I'd say we create an issue for JCR 2.1 and propose a weaker contract.
>
> Regards
> Marcel
>
>
> On 08/07/14 17:52, "Michael Dürig" <md...@apache.org> wrote:
>
>>
>> Hi,
>>
>> Often it would be helpful if observation events would carry node type
>> information. In Oak we added some initial support for this [1] by adding
>> the node type and the mixin types of the associated node of an event to
>> the info map.
>>
>> In JCR-3765 [2] I suggested to backport this functionality to
>> Jackrabbit. However this will cause the GetInfoTest TCK test to fail.
>> That test asserts that the info map is empty for all non move events.
>> What do people think about adapting the test expectations of this test
>> and allow for said entries?
>>
>> Michael
>>
>>
>> [1] https://issues.apache.org/jira/browse/OAK-1661
>> [2] https://issues.apache.org/jira/browse/JCR-3765
>
Re: NodeType information in observation events
Posted by Marcel Reutegger <mr...@adobe.com>.
Hi,
we probably have the TCK test in place because the spec explicitly
says the map is empty in those cases. see 12.3.2 Event Information.
on the other hand, I don't see a reason why an implementation shouldn't
be allowed to pass more information than required.
I'd say we create an issue for JCR 2.1 and propose a weaker contract.
Regards
Marcel
On 08/07/14 17:52, "Michael Dürig" <md...@apache.org> wrote:
>
>Hi,
>
>Often it would be helpful if observation events would carry node type
>information. In Oak we added some initial support for this [1] by adding
>the node type and the mixin types of the associated node of an event to
>the info map.
>
>In JCR-3765 [2] I suggested to backport this functionality to
>Jackrabbit. However this will cause the GetInfoTest TCK test to fail.
>That test asserts that the info map is empty for all non move events.
>What do people think about adapting the test expectations of this test
>and allow for said entries?
>
>Michael
>
>
>[1] https://issues.apache.org/jira/browse/OAK-1661
>[2] https://issues.apache.org/jira/browse/JCR-3765