You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Technoboy- (via GitHub)" <gi...@apache.org> on 2024/09/05 08:53:13 UTC
Re: [PR] [fix][broker] fix pulsar-admin topics stats-internal caused a BK client thread a deadlock [pulsar]
Technoboy- commented on code in PR #23258:
URL: https://github.com/apache/pulsar/pull/23258#discussion_r1745075593
##########
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java:
##########
@@ -304,8 +306,10 @@ static CompletableFuture<List<Entry>> readEntries(LedgerHandle lh, long from, lo
* Getter for CompactedTopicContext.
* @return CompactedTopicContext
*/
- public Optional<CompactedTopicContext> getCompactedTopicContext() throws ExecutionException, InterruptedException {
- return compactedTopicContext == null ? Optional.empty() : Optional.of(compactedTopicContext.get());
+ public Optional<CompactedTopicContext> getCompactedTopicContext() throws ExecutionException, InterruptedException,
Review Comment:
Why do we fix here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org