You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Danielius Jurna (JIRA)" <ji...@apache.org> on 2008/12/15 09:27:05 UTC
[jira] Created: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
--------------------------------------------------------------------
Key: AMQ-2033
URL: https://issues.apache.org/activemq/browse/AMQ-2033
Project: ActiveMQ
Issue Type: Bug
Components: Broker
Affects Versions: 5.2.0
Reporter: Danielius Jurna
Priority: Critical
It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
producerWindow.start();
I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Danielius Jurna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Danielius Jurna updated AMQ-2033:
---------------------------------
Attachment: (was: producer.patch)
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Assignee: Gary Tully
> Priority: Critical
> Fix For: 5.3.0
>
> Attachments: producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Danielius Jurna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Danielius Jurna updated AMQ-2033:
---------------------------------
Attachment: ProducerFlowControlTest.patch
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Priority: Critical
> Attachments: producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Danielius Jurna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Danielius Jurna updated AMQ-2033:
---------------------------------
Attachment: ProducerFlowControlTest.java
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Priority: Critical
> Attachments: producer.patch, ProducerFlowControlTest.java
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Danielius Jurna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Danielius Jurna reopened AMQ-2033:
----------------------------------
Now prducer has thread leak, because it doesn't close producerWindow on producer close. I've attached patch, which closes the producer window (this patch includes both fixes).
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Assignee: Gary Tully
> Priority: Critical
> Fix For: 5.3.0
>
> Attachments: producer.patch, producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Tully resolved AMQ-2033.
-----------------------------
Resolution: Fixed
I added a close to the original commit so the close (same as your second patch) is currently on trunk: see the [diff|http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQMessageProducer.java?p2=%2Factivemq%2Ftrunk%2Factivemq-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Factivemq%2FActiveMQMessageProducer.java&p1=%2Factivemq%2Ftrunk%2Factivemq-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Factivemq%2FActiveMQMessageProducer.java&r1=727353&r2=727352&view=diff&pathrev=727353]
Re the thread usage, and thread per producer. Please open another issue for that as SystemUsage may need a little refactor to obtain a thread pool or executor reference.
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Assignee: Gary Tully
> Priority: Critical
> Fix For: 5.3.0
>
> Attachments: producer.patch, producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Danielius Jurna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48318#action_48318 ]
Danielius Jurna commented on AMQ-2033:
--------------------------------------
Now with this patch, there is one thread for every producer created. On heavy systems, there are big amount of threads created (hundreds) and waiting, because every producerWindow has it's own thread executor. I thing they should reuse session thread pool or smth. Should I create new issue for this?
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Assignee: Gary Tully
> Priority: Critical
> Fix For: 5.3.0
>
> Attachments: producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Danielius Jurna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Danielius Jurna updated AMQ-2033:
---------------------------------
Attachment: producer.patch
Patch wich includes producer window stop
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Assignee: Gary Tully
> Priority: Critical
> Fix For: 5.3.0
>
> Attachments: producer.patch, producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Danielius Jurna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Danielius Jurna updated AMQ-2033:
---------------------------------
Attachment: producer.patch
Updated
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Assignee: Gary Tully
> Priority: Critical
> Fix For: 5.3.0
>
> Attachments: producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48196#action_48196 ]
Gary Tully commented on AMQ-2033:
---------------------------------
This looks like a good catch.
w.r.t the test case you mentioned, do you also have a patch for the ProducerFlowControlTest. The ProducerFlowControlTest.java attachment is the same as the current trunk revision.
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Priority: Critical
> Attachments: producer.patch, ProducerFlowControlTest.java
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Danielius Jurna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Danielius Jurna updated AMQ-2033:
---------------------------------
Attachment: producer.patch
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Priority: Critical
> Attachments: producer.patch, ProducerFlowControlTest.java
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Tully resolved AMQ-2033.
-----------------------------
Resolution: Fixed
Fix Version/s: 5.3.0
patch applied in r727353. Thanks for the fix and the test case,
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Assignee: Gary Tully
> Priority: Critical
> Fix For: 5.3.0
>
> Attachments: producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Danielius Jurna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48202#action_48202 ]
Danielius Jurna commented on AMQ-2033:
--------------------------------------
Sorry, here is the patch for ProducerFlowControlTest
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Priority: Critical
> Attachments: producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AMQ-2033) Deadlock on
producerWindow.waitForSpace() in ActiveMQMessageProducer
Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Tully reassigned AMQ-2033:
-------------------------------
Assignee: Gary Tully
> Deadlock on producerWindow.waitForSpace() in ActiveMQMessageProducer
> --------------------------------------------------------------------
>
> Key: AMQ-2033
> URL: https://issues.apache.org/activemq/browse/AMQ-2033
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Reporter: Danielius Jurna
> Assignee: Gary Tully
> Priority: Critical
> Attachments: producer.patch, ProducerFlowControlTest.java, ProducerFlowControlTest.patch
>
>
> It seems, that producer throttling with producerWindow enabled doesn't work at all. I'm attaching unit test for this. After sending about ~80msg producer stops and never resumes sending.
> The problem is that producerWindow is not started ActiveMQMessageProducer. There must be something like this:
> producerWindow.start();
> I'm also attaching patch for this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.