You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/23 17:20:51 UTC

[GitHub] StefanRRichter commented on a change in pull request #7153: FLINK-10918 Fix the checkpoint dir creation error on Window for keyed rocksdb state

StefanRRichter commented on a change in pull request #7153: FLINK-10918 Fix the checkpoint dir creation error on Window for keyed rocksdb state
URL: https://github.com/apache/flink/pull/7153#discussion_r235995727
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ##########
 @@ -575,7 +585,7 @@ private RocksDB openDB(
 		try {
 			dbRef = RocksDB.open(
 				Preconditions.checkNotNull(dbOptions),
-				Preconditions.checkNotNull(path),
+				Preconditions.checkNotNull(Utils.getPathAsString(new Path(path))),
 
 Review comment:
   Nit: Like this, the null check does not ensure that `path`is non-null, but the return value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services