You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Neha Narkhede (JIRA)" <ji...@apache.org> on 2012/07/29 21:31:34 UTC
[jira] [Comment Edited] (KAFKA-384) Fix intermittent test failures
and remove unnecessary sleeps
[ https://issues.apache.org/jira/browse/KAFKA-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424610#comment-13424610 ]
Neha Narkhede edited comment on KAFKA-384 at 7/29/12 7:31 PM:
--------------------------------------------------------------
This patch removes sleep statements from the unit tests. Changes include -
1. All sleep statements except those related to a scheduler are removed. So 2-3 sleep statements that exercise the producer side queue expiration logic have not been removed
2. For the Log tests, passed in a Time parameter to the Log. Kafka server already takes in an optional Time parameter that defaults to SystemTime. However, it wasn't passed around in LogManager. Fixed it so KafkaServer passes its Time
variable to LogManager which passes it to Log.
This is useful in removing all sleep statements from unit tests for the log manager and logs
was (Author: nehanarkhede):
This patch removes sleep statements from the unit tests. Changes include -
1. All sleep statements except those related to a scheduler are removed. This includes the producer side queue expiration logic
2. For the Log tests, passed in a Time parameter to the Log. Kafka server already takes in an optional Time parameter that defaults to SystemTime. However, it wasn't passed around in LogManager. Fixed it so KafkaServer passes its Time
variable to LogManager which passes it to Log.
This is useful in removing all sleep statements from unit tests for the log manager and logs
> Fix intermittent test failures and remove unnecessary sleeps
> ------------------------------------------------------------
>
> Key: KAFKA-384
> URL: https://issues.apache.org/jira/browse/KAFKA-384
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Joel Koshy
> Assignee: Neha Narkhede
> Attachments: kafka-384-v1.patch
>
>
> Seeing intermittent failures in 0.8 unit tests. Also, many sleeps can be removed (with producer acks in place) and I think MockTime isn't used in some places where it should.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira