[GitHub] [arrow-datafusion] isidentical commented on a diff in pull request #4242: Support binary boolean operators with nulls

[GitBox <gi...@apache.org>]

isidentical commented on code in PR #4242:
URL: https://github.com/apache/arrow-datafusion/pull/4242#discussion_r1024076912


##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -1022,6 +1026,30 @@ mod tests {
             Operator::Or,
             DataType::Boolean
         );
+        test_coercion_binary_rule!(
+            DataType::Boolean,
+            DataType::Null,
+            Operator::And,
+            DataType::Boolean
+        );

Review Comment:
   I guess it makes sense to also add the last 2 combinations (`null and $bool` & `null or $bool`)
   ```rs
   test_coercion_binary_rule!(
           DataType::Null,
           DataType::Boolean,
           Operator::And,
           DataType::Boolean
   );
   test_coercion_binary_rule!(
           DataType::Null,
           DataType::Boolean,
           Operator::Or,
           DataType::Boolean
   );
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org