You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2025/10/11 16:31:46 UTC
[PR] [fix](iceberg) fix logic of getting namespaces [doris]
morningman opened a new pull request, #56874:
URL: https://github.com/apache/doris/pull/56874
### What problem does this PR solve?
Followup #56415
Problem Summary:
1. The previous `getNamespace` logic is wrong, we should split the `dbName` by `.` to create namespaces.
2. Allow not specify `oauth.uri` of iceberg rest catalog, to follow the new spec of IRC
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg) fix logic of getting namespaces [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56874:
URL: https://github.com/apache/doris/pull/56874#issuecomment-3406942143
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg) fix logic of getting namespaces [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56874:
URL: https://github.com/apache/doris/pull/56874#issuecomment-3393915024
# FE UT Coverage Report
Increment line coverage ` 76.92% (10/13)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56874_288a734f90c529753e30297def9d1839e3def750/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56874_288a734f90c529753e30297def9d1839e3def750/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg) fix logic of getting namespaces [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56874:
URL: https://github.com/apache/doris/pull/56874#issuecomment-3393480183
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg) fix logic of getting namespaces [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #56874:
URL: https://github.com/apache/doris/pull/56874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg) fix logic of getting namespaces [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #56874:
URL: https://github.com/apache/doris/pull/56874#issuecomment-3393875944
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg) fix logic of getting namespaces [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56874:
URL: https://github.com/apache/doris/pull/56874#issuecomment-3393901530
<details>
<summary>ClickBench: <b>Total hot run time: 30.54 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 288a734f90c529753e30297def9d1839e3def750, data reload: false
query1 0.05 0.05 0.05
query2 0.09 0.05 0.06
query3 0.25 0.08 0.08
query4 1.60 0.12 0.11
query5 0.27 0.27 0.25
query6 1.17 0.66 0.64
query7 0.04 0.03 0.03
query8 0.06 0.05 0.05
query9 0.62 0.54 0.52
query10 0.60 0.59 0.58
query11 0.16 0.11 0.12
query12 0.15 0.12 0.12
query13 0.63 0.61 0.63
query14 1.03 1.05 1.02
query15 0.90 0.84 0.86
query16 0.40 0.39 0.40
query17 1.04 1.05 1.05
query18 0.21 0.20 0.20
query19 1.99 1.83 1.86
query20 0.02 0.02 0.01
query21 15.43 0.92 0.56
query22 0.78 1.21 0.73
query23 14.81 1.38 0.64
query24 6.76 0.87 1.09
query25 0.46 0.23 0.07
query26 0.59 0.17 0.13
query27 0.07 0.05 0.06
query28 10.20 1.40 0.92
query29 12.58 4.03 3.38
query30 0.28 0.13 0.11
query31 2.83 0.61 0.39
query32 3.23 0.57 0.48
query33 3.09 3.24 3.04
query34 16.17 5.44 4.81
query35 4.94 4.93 4.94
query36 0.71 0.52 0.50
query37 0.10 0.08 0.07
query38 0.07 0.05 0.04
query39 0.04 0.03 0.03
query40 0.18 0.17 0.16
query41 0.08 0.03 0.04
query42 0.04 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 104.77 s
Total hot run time: 30.54 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg) fix logic of getting namespaces [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56874:
URL: https://github.com/apache/doris/pull/56874#issuecomment-3393973695
# FE Regression Coverage Report
Increment line coverage ` 7.69% (1/13)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56874_288a734f90c529753e30297def9d1839e3def750_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56874_288a734f90c529753e30297def9d1839e3def750_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg) fix logic of getting namespaces [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56874:
URL: https://github.com/apache/doris/pull/56874#issuecomment-3406942370
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org