You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/05/03 13:22:49 UTC
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/839
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
A feed might cause the system to freeze when connected to
a dataset that has secondary indexes. This case happen if
a frame contains all duplicate records pass the primary index
insert operator. The root cause is that the assign runtime in
the pipeline assumes at least a single record. Hence, a corrupted
tuple will reach the commit operator which will create a bad log
record with a PK of size 0. The log record will cause the log
flusher thread to die.
Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
---
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.2.lib.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.3.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.4.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.5.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.6.lib.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.7.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
10 files changed, 389 insertions(+), 76 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/39/839/1
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
Patch Set 1: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1286/ : ABORTED
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/839
to look at the new patch set (#3).
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
A feed might cause the system to freeze when connected to
a dataset that has secondary indexes. This case happen if
a frame contains all duplicate records pass the primary index
insert operator. The root cause is that the assign runtime in
the pipeline assumes at least a single record. Hence, a corrupted
tuple will reach the commit operator which will create a bad log
record with a PK of size 0. The log record will cause the log
flusher thread to die.
Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
---
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.2.lib.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.3.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.4.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.5.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.6.lib.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.7.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
10 files changed, 329 insertions(+), 14 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/39/839/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
Patch Set 2: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1287/ : ABORTED
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1286/
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
Patch Set 3: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1288/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1288/
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has uploaded a new patch set (#2).
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
A feed might cause the system to freeze when connected to
a dataset that has secondary indexes. This case happen if
a frame contains all duplicate records pass the primary index
insert operator. The root cause is that the assign runtime in
the pipeline assumes at least a single record. Hence, a corrupted
tuple will reach the commit operator which will create a bad log
record with a PK of size 0. The log record will cause the log
flusher thread to die.
Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
---
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.2.lib.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.3.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.4.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.5.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.6.lib.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.7.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
10 files changed, 326 insertions(+), 14 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/39/839/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1287/
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has submitted this change and it was merged.
Change subject: ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
......................................................................
ASTERIXDB-1415 Fix Feed Freeze with Indexed Dataset
A feed might cause the system to freeze when connected to
a dataset that has secondary indexes. This case happen if
a frame contains all duplicate records pass the primary index
insert operator. The root cause is that the assign runtime in
the pipeline assumes at least a single record. Hence, a corrupted
tuple will reach the commit operator which will create a bad log
record with a PK of size 0. The log record will cause the log
flusher thread to die.
Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Reviewed-on: https://asterix-gerrit.ics.uci.edu/839
Reviewed-by: Till Westmann <ti...@apache.org>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.2.lib.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.3.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.4.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.5.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.6.lib.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.7.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feed-with-multiple-indexes/feed-with-multiple-indexes.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
10 files changed, 329 insertions(+), 14 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified
--
To view, visit https://asterix-gerrit.ics.uci.edu/839
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0fa0bc08cf4224dcf64f83ea72c227f63affc73
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>