You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/03/02 02:10:50 UTC
Review Request 44243: Updated master to ignore 'Subscribe.force' for
HTTP framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44243/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Greg Mann.
Bugs: MESOS-4712
https://issues.apache.org/jira/browse/MESOS-4712
Repository: mesos
Description
-------
Master always closes any old active streaming connection when it gets a
SUBSCRIBE request.
Diffs
-----
src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108
Diff: https://reviews.apache.org/r/44243/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 44243: Updated master to ignore 'Subscribe.force'
for HTTP framework.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44243/#review121671
-----------------------------------------------------------
Fix it, then Ship it!
LGTM.
src/master/master.cpp (line 2107)
<https://reviews.apache.org/r/44243/#comment183438>
Let's add a link to the JIRA for posterity since this behavior is different than for frameworks connected via driver.
- Anand Mazumdar
On March 2, 2016, 1:10 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44243/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 1:10 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-4712
> https://issues.apache.org/jira/browse/MESOS-4712
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Master always closes any old active streaming connection when it gets a
> SUBSCRIBE request.
>
>
> Diffs
> -----
>
> src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108
>
> Diff: https://reviews.apache.org/r/44243/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 44243: Updated master to ignore 'Subscribe.force'
for HTTP framework.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44243/#review121697
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On March 2, 2016, 1:10 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44243/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 1:10 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-4712
> https://issues.apache.org/jira/browse/MESOS-4712
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Master always closes any old active streaming connection when it gets a
> SUBSCRIBE request.
>
>
> Diffs
> -----
>
> src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108
>
> Diff: https://reviews.apache.org/r/44243/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>