You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/05 17:51:53 UTC

[GitHub] apeforest commented on a change in pull request #12749: [MXNET-1029] Feature request: randint operator

apeforest commented on a change in pull request #12749: [MXNET-1029] Feature request: randint operator
URL: https://github.com/apache/incubator-mxnet/pull/12749#discussion_r230843605
 
 

 ##########
 File path: include/mxnet/random_generator.h
 ##########
 @@ -71,14 +71,23 @@ class RandGenerator<cpu, DType> {
       return dist_uniform(*engine_);
     }
 
+    MSHADOW_XINLINE int64_t discrete_uniform(const int64_t lower, const int64_t upper) {
 
 Review comment:
   Why use a fixed type int64_t?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services