SLING-4318 servlet that lists versions, potential conflict with V selector

[Bertrand Delacretaz <bd...@apache.org>]

Hi,

For SLING-4318 Tomek's contribution uses the V selector that I
suggested so that foo.V.json lists the versions of the foo node.

Putting this servlet in our servlets.get bundle might interfere with
existing user servlets that use this selector.

How should we avoid this potential collision? Put the new servlet in a
different bundle? Make its selector configurable?

-Bertrand

Re: SLING-4318 servlet that lists versions, potential conflict with V selector

[Tomek Rękawek <to...@cognifide.com>]

Hi Bertrand,

On Thu, Jan 29, 2015 at 2:48 PM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:

> ...ideally it should first check that
> the servlet is disabled, then enable it via config, wait for the
> config to be active and then run the tests that I added. Probably best
> to move that to a new test class then.
>

I integrated tests with the pull request, extracted it to a new class and
added a new test case to check if the lack of the configuration disables
the servlet. Test class is
called o.a.s.l.webapp.integrationtest.VersionInfoServletTest.

Regards,
Tomek

-- 
Tomek Rękawek
Senior Software Engineer

Cognifide Polska Sp. z o.o.
skype: trekawek

www.cognifide.com

Re: SLING-4318 servlet that lists versions, potential conflict with V selector

[Bertrand Delacretaz <bd...@apache.org>]

Hi Tomek,

On Wed, Jan 28, 2015 at 10:34 PM, Tomek Rękawek
<to...@cognifide.com> wrote:
>...I can add the ConfigurationPolicy and set the configuration as
> metatype, so users can create their configuration via Felix Console....

Sounds good to me - this will require some changes to the integration
test that I attached to SLING-4318, ideally it should first check that
the servlet is disabled, then enable it via config, wait for the
config to be active and then run the tests that I added. Probably best
to move that to a new test class then.

-Bertrand

Re: SLING-4318 servlet that lists versions, potential conflict with V selector

[Tomek Rękawek <to...@cognifide.com>]

Hello Justin,

On Wed, Jan 28, 2015 at 8:14 PM, Justin Edelson <ju...@justinedelson.com>
wrote:

> How about using ConfigurationPolicy.REQUIRE for this so that it needs
> to be manually enabled? I suspect that's probably a good idea for this
> feature anyway even if there was no potential collision.
>

Great idea! I can add the ConfigurationPolicy and set the configuration as
metatype, so users can create their configuration via Felix Console.

Bertrand, WDYT?

Regards,
Tomek


> On Wed, Jan 28, 2015 at 12:33 PM, Bertrand Delacretaz
> <bd...@apache.org> wrote:
> > Hi,
> >
> > For SLING-4318 Tomek's contribution uses the V selector that I
> > suggested so that foo.V.json lists the versions of the foo node.
> >
> > Putting this servlet in our servlets.get bundle might interfere with
> > existing user servlets that use this selector.
> >
> > How should we avoid this potential collision? Put the new servlet in a
> > different bundle? Make its selector configurable?
> >
> > -Bertrand
>



-- 
Tomek Rękawek
Senior Software Engineer

Cognifide Polska Sp. z o.o.
skype: trekawek

www.cognifide.com

Re: SLING-4318 servlet that lists versions, potential conflict with V selector

[Justin Edelson <ju...@justinedelson.com>]

How about using ConfigurationPolicy.REQUIRE for this so that it needs
to be manually enabled? I suspect that's probably a good idea for this
feature anyway even if there was no potential collision.

Regards,
Justin

On Wed, Jan 28, 2015 at 12:33 PM, Bertrand Delacretaz
<bd...@apache.org> wrote:
> Hi,
>
> For SLING-4318 Tomek's contribution uses the V selector that I
> suggested so that foo.V.json lists the versions of the foo node.
>
> Putting this servlet in our servlets.get bundle might interfere with
> existing user servlets that use this selector.
>
> How should we avoid this potential collision? Put the new servlet in a
> different bundle? Make its selector configurable?
>
> -Bertrand