You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/03 15:52:39 UTC
[jira] [Commented] (CB-10176) Cordova-common should contain a
default logger implementation.
[ https://issues.apache.org/jira/browse/CB-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130513#comment-15130513 ]
ASF GitHub Bot commented on CB-10176:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/375
CB-10176 Adds CordovaLogger class, based on logger module from cordova-cli
This is an implementation for [CB-10176](https://issues.apache.org/jira/browse/CB-10176)
This PR adds a standard logger implementation, that could be reused by cli and platforms.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10176
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/375.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #375
----
commit 1fd2dd857dca026483d869660e79784f392921d0
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-02-03T14:47:24Z
CB-10176 Adds CordovaLogger class, based on logger module from cordova-cli
----
> Cordova-common should contain a default logger implementation.
> --------------------------------------------------------------
>
> Key: CB-10176
> URL: https://issues.apache.org/jira/browse/CB-10176
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaCommon
> Affects Versions: 1.0.0
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: triaged
> Fix For: 1.1.0
>
>
> Currently ConsoleLogger, which is used for logging, when platform is not supplied with EventEmitter, is duplicated across each platform.
> The same logic is already lives in CLI.
> To reduce code duplication it should be moved to 'common'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org