You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2017/08/04 04:06:50 UTC
Review Request 61422: Check for config group host mapping left behind
after host delete
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61422/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Vitalyi Brodetskyi.
Bugs: AMBARI-21658
https://issues.apache.org/jira/browse/AMBARI-21658
Repository: ambari
Description
-------
Delete hosts deletes the config group host mapping as well, however, certain older versions of Ambari have reported seeing orphaned mappings in the configgrouphostmapping table.
This results in Add Service wizard being stuck with the following error message:
{code}
This is a JS issue. No exceptions/error in Ambari server logs:
Uncaught TypeError: Cannot read property 'id' of undefined
at http://192.167.42.111:8080/javascripts/app.js:37021:96
at Array.map (native)
at Class.<anonymous>
{code}
The patch addresses identifying such an error on server start and providing a way to fix it automatically.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java c6239d8
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java d35fc1a
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java 03edcf8
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 9c8eb74
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java 3f73657
Diff: https://reviews.apache.org/r/61422/diff/1/
Testing
-------
Verified manually.
Unit test added.
Thanks,
Sid Wagle
Re: Review Request 61422: Check for config group host mapping left
behind after host delete
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61422/#review182186
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Aug. 4, 2017, 4:06 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61422/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2017, 4:06 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21658
> https://issues.apache.org/jira/browse/AMBARI-21658
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Delete hosts deletes the config group host mapping as well, however, certain older versions of Ambari have reported seeing orphaned mappings in the configgrouphostmapping table.
>
> This results in Add Service wizard being stuck with the following error message:
>
> {code}
> This is a JS issue. No exceptions/error in Ambari server logs:
> Uncaught TypeError: Cannot read property 'id' of undefined
> at http://192.167.42.111:8080/javascripts/app.js:37021:96
> at Array.map (native)
> at Class.<anonymous>
> {code}
>
> The patch addresses identifying such an error on server start and providing a way to fix it automatically.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java c6239d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java d35fc1a
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java 03edcf8
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 9c8eb74
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java 3f73657
>
>
> Diff: https://reviews.apache.org/r/61422/diff/1/
>
>
> Testing
> -------
>
> Verified manually.
> Unit test added.
>
>
> Thanks,
>
> Sid Wagle
>
>