You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@apr.apache.org by bu...@apache.org on 2017/10/19 09:08:40 UTC
[Bug 61636] New: testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
Bug ID: 61636
Summary: testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Product: APR
Version: HEAD
Hardware: PC
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: APR test
Assignee: bugs@apr.apache.org
Reporter: michal.babacek@gmail.com
Target Milestone: ---
Call to action: Make testcrypto configurable
Original post to the APR Dev list:
Hi guys,
I've switched my Windows CI from APR Util 1.5.x
to the 1.6.x branch. Little did I know it would
demand NSS even though I built with OpenSSL.
This is the pertinent excerpt from the log [1],
the full build log (large text) can be found here [2]
and last but not least, this is the build script [3],
note that I tried to set -DAPU_HAVE_NSS=OFF out of good
sport, but it was in vain.
Could you tell me what might be improved in the
CMakeLists.txt so as the test run doesn't look for NSS?
Is there anything else fishy about it? Perhaps the root
cause is entirely different.
Thank you for any pointers
Cheers
Karm
[1] https://www.hastebin.com/umitizokor.lua
[2] https://ci.modcluster.io/job/apr-util-windows/15/label=w2k12r2/consoleText
[3]
https://github.com/modcluster/ci.modcluster.io/blob/6a01bf9f015224271078336eebab4e258b8f9196/windows/apr-util/build.bat#L28
Michal Karm Babacek
--
Sent from my Hosaka Ono-Sendai Cyberspace 7
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
--- Comment #6 from jfclere <jf...@gmail.com> ---
actually get_nss_driver() and get_openssl_driver() can test what apr-util is
capable doing, can't we use those to find what we can test?
May with a flag checking APU_HAVE_NSS, APU_HAVE_OPENSSL,
APU_HAVE_COMMONCRYPTO in case we run the against what we have just compiled...
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
--- Comment #2 from Michal Karm Babacek <mi...@gmail.com> ---
Created attachment 35441
--> https://bz.apache.org/bugzilla/attachment.cgi?id=35441&action=edit
Patch for testcrypto.c
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
--- Comment #1 from Michal Karm Babacek <mi...@gmail.com> ---
I'll add a conf option.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
--- Comment #3 from Michal Karm Babacek <mi...@gmail.com> ---
Regarding the patch: attachment 35441 (GitHub branch [1])
The default behavior remains the same, see [2].
Three new env props can be optionally set, APU_TEST_NSS=on|off,
APU_TEST_OPENSSL=on|off, APU_TEST_COMMONCRYPTO=on|off
Here is an example with my build where I have only OpenSSL crypto available
(apr_crypto_openssl dlls):
> C:\Users\karm\source\apr-util\karm-vs\Debug (1.6.x)
> λ set APU_TEST_NSS=off & set APU_TEST_COMMONCRYPTO=off & set "PATH=C:\tmp\apr\bin\;C:\tmp\libexpat-R_2_2_0-64\bin\;C:\tmp\OpenSSL_1_0_2h-64\bin\;%PATH%" & .\testall.exe -v testcrypto
> testcrypto : SUCCESS
> /Error 730061 occurred attempting to reach memcached on localhost:11211. Skipping apr_memcache tests...
> /Error 730061 occurred attempting to reach Redis on localhost:6379. Skipping apr_redis tests...
> All tests passed.
Legit? WDYT?
Cheers
Karm
[1] https://github.com/Karm/apr-util/tree/1.6.x-BZ-61636
[2] http://www.mergely.com/T2Hd0zGd/
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
William A. Rowe Jr. <wr...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
--- Comment #4 from Michal Karm Babacek <mi...@gmail.com> ---
Passing build:
https://ci.modcluster.io/job/apr-util-windows/16/label=w2k12r2/consoleText
Build script:
https://github.com/modcluster/ci.modcluster.io/tree/master/windows/apr-util
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
--- Comment #7 from Michal Karm Babacek <mi...@gmail.com> ---
I'll post a different patch that won't use env props then...
I'm gonna explore get_*driver first, because APU_HAVE_* smells of #ifdefs,
IIUC.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
Michal Karm Babacek <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |michal.babacek@gmail.com
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
William A. Rowe Jr. <wr...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #35441|1 |0
is patch| |
--- Comment #5 from William A. Rowe Jr. <wr...@apache.org> ---
Comment on attachment 35441
--> https://bz.apache.org/bugzilla/attachment.cgi?id=35441
Patch for testcrypto.c
Reviewing the patch, I'd rather see us inspect APU_HAVE_NSS, APU_HAVE_OPENSSL,
APU_HAVE_COMMONCRYPTO as emitted from the configure phase in our private or
public headers. We don't rely on envvars elsewhere in the test framework.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 61636] testcrypto tries to test both OpenSSL and NSS,
regardless of what it was built with
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61636
Yann Ylavic <yl...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #35441|application/mbox |text/plain
mime type| |
Attachment #35441|0 |1
is patch| |
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org