You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "resyfer (via GitHub)" <gi...@apache.org> on 2024/02/02 21:37:14 UTC
[PR] fs/vfat: Fix typo in the macro DIRSEC_BYTENDX [nuttx]
resyfer opened a new pull request, #11647:
URL: https://github.com/apache/nuttx/pull/11647
The `DIRSEC_BYTENDX(f, i)` is supposed to have `DIRSEC_NDXMASK(f)` in its expansion instead of `DIRSEC_NDXMASK(fs)`. It went unnoticed in the codebase as `DIRSEC_BYTENDX(fs, idx)` is the way it is used, and it leads to a similar expansion as desired, and thus it has worked till now without any issues from this.
## Summary
fs/vfat: Fix typo in the macro DIRSEC_BYTENDX
## Impact
None
## Testing
Build and Checkpatch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fs/vfat: Fix typo in the macro DIRSEC_BYTENDX [nuttx]
Posted by "resyfer (via GitHub)" <gi...@apache.org>.
resyfer commented on code in PR #11647:
URL: https://github.com/apache/nuttx/pull/11647#discussion_r1476971523
##########
.gitignore:
##########
@@ -63,3 +63,5 @@ uImage
.DS_Store
tools/gdb/__pycache__
/build
+.ccls-cache
+compile_commands.json
Review Comment:
`compile_commands.json` is a file that lists the exact compiler calls for each file (that gets compiled). This helps language servers to build their internal AST. CMake [allows it out of the box](https://cmake.org/cmake/help/latest/variable/CMAKE_EXPORT_COMPILE_COMMANDS.html) and so does clang, or it can be created using a CLI tool like `bear` or `compiledb`.
It's a pretty popular file that all popular C/C++ LSPs use, and even the Linux kernel has a [dedicated script to generate it](https://github.com/torvalds/linux/blob/master/scripts/clang-tools/gen_compile_commands.py).
Since this lists exact compiler calls, it might be different depending on need, branch, state of the code, etc., it is kept in .gitignore.
---
CCLS is one such LSP, which also creates a `.ccls-cache` directory for caching the AST of the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fs/vfat: Fix typo in the macro DIRSEC_BYTENDX [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #11647:
URL: https://github.com/apache/nuttx/pull/11647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fs/vfat: Fix typo in the macro DIRSEC_BYTENDX [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #11647:
URL: https://github.com/apache/nuttx/pull/11647#discussion_r1476814030
##########
.gitignore:
##########
@@ -63,3 +63,5 @@ uImage
.DS_Store
tools/gdb/__pycache__
/build
+.ccls-cache
+compile_commands.json
Review Comment:
Why did you include these file to .gitignore ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fs/vfat: Fix typo in the macro DIRSEC_BYTENDX [nuttx]
Posted by "resyfer (via GitHub)" <gi...@apache.org>.
resyfer commented on code in PR #11647:
URL: https://github.com/apache/nuttx/pull/11647#discussion_r1476971523
##########
.gitignore:
##########
@@ -63,3 +63,5 @@ uImage
.DS_Store
tools/gdb/__pycache__
/build
+.ccls-cache
+compile_commands.json
Review Comment:
`compile_commands.json` is a file that lists the exact compiler calls for each file (that gets compiled). This helps language servers to build their internal AST. CMake [allows it out of the box](https://cmake.org/cmake/help/latest/variable/CMAKE_EXPORT_COMPILE_COMMANDS.html) and so does clang, or it can be created using a CLI tool like `bear` or `compiledb`.
It's a pretty popular file that all C/C++ LSPs use, and even the Linux kernel has a [dedicated script to generate it](https://github.com/torvalds/linux/blob/master/scripts/clang-tools/gen_compile_commands.py).
Since this lists exact compiler calls, it might be different depending on need, branch, state of the code, etc., it is kept in .gitignore.
---
CCLS is one such LSP, which also creates a `.ccls-cache` directory for caching the AST of the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org