[GitHub] [incubator-pinot] siddharthteotia edited a comment on pull request #6043: Add IN_PARTITIONED_SUBQUERY support

[GitBox <gi...@apache.org>]

siddharthteotia edited a comment on pull request #6043:
URL: https://github.com/apache/incubator-pinot/pull/6043#issuecomment-706658108


   I think we are having mixed semantics here. Even though it is a combination of 2 queries, our implementation is a transform function. It is not a correct subquery syntax that we usually see in other systems. 
   
   The name of the transform functions should not contain subquery since it is implementation detail. On that  note, don't think transform function should even be used to implement subquery semantics in Pinot since that is not the standard SQL semantics. 
   
   We should just have the inner query in parentheses to implement a proper non correlated subquery in SQL. Is it absolutely necessary to have this subquery specified in a transform function?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org